postpone db update for when it is really needed

[mpd-feeder.git] / bin / mpd-feeder

diff --git a/bin/mpd-feeder b/bin/mpd-feeder
index 097a7a654f3110d2ca1048540285efc5241932eb..3ba943234f6900e1ab32abb342edfa7e7a2931fb 100755 (executable)
--- a/bin/mpd-feeder
+++ b/bin/mpd-feeder
@@ -244,46 +244,45 @@ SQL
         $self->connect_mpd;
         $self->connect_db;
 
-        $mpd->send('listallinfo')->on_done(
-            sub {
-                try {
-                    my $rows = shift;
-                    $db->begin_work;
+        my $rows = $mpd->send('listallinfo')->get;
+        try {
+            $db->begin_work;
 
-                    $db_generation++;
+            $db_generation++;
 
-                    my $song_count;
+            my $song_count;
 
-                    foreach my $entry (@$rows) {
-                        next unless exists $entry->{file};
-                        $self->db_store_song( $entry->{file},
-                            $entry->{Artist}, $entry->{Album} );
-                        $song_count++;
-                    }
+            foreach my $entry (@$rows) {
+                next unless exists $entry->{file};
+                $self->db_store_song( $entry->{file},
+                    $entry->{Artist}, $entry->{Album} );
+                $song_count++;
+            }
 
-                    $log->info("Updated data about $song_count songs");
+            $log->info("Updated data about $song_count songs");
 
-                    $self->db_remove_stale_entries;
+            $self->db_remove_stale_entries;
 
-                    $self->db_set_option( generation => $db_generation );
+            $self->db_set_option( generation => $db_generation );
 
-                    $db->commit;
-                }
-                catch {
-                    my $err = $@;
+            $db->commit;
 
-                    $db_generation--;
+            $db_needs_update = 0;
+        }
+        catch {
+            my $err = $@;
 
-                    $db->rollback;
+            $db_generation--;
 
-                    die $err;
-                }
-            }
-        );
+            $db->rollback;
+
+            die $err;
+        }
     }
 
     method db_find_suitable_songs($num) {
         $self->connect_db;
+        $self->update_db;
 
         my @result;
         my $sth = $db->prepare_cached(<<SQL);
@@ -363,7 +362,6 @@ SQL
         }
         $self->connect_mpd;
         my $f = $mpd->send( \@commands );
-        warn "here";
         $f->on_fail( sub { die @_ } );
         $f->on_done(
             sub {
@@ -372,8 +370,6 @@ SQL
                 $callback->(@_) if $callback;
             }
         );
-
-        warn "here";
     }
 
     method prepare_to_wait_idle {
@@ -382,10 +378,9 @@ SQL
             sub {
                 warn $_ for @_;
                 my $result = shift;
-                use JSON; warn to_json($result);
 
                 if ( $result->{changed} eq 'database' ) {
-                    $self->update_db(1);
+                    $db_needs_update = 1;
                     $self->prepare_to_wait_idle;
                 }
                 elsif ( $result->{changed} eq 'playlist' ) {
@@ -443,7 +438,6 @@ if (@ARGV) {
     }
 }
 
-
 $feeder->queue_songs( undef, sub { $feeder->run } );
 
 $feeder->mpd->loop->run;