make database update a synchronous operation

[mpd-feeder.git] / bin / mpd-feeder

diff --git a/bin/mpd-feeder b/bin/mpd-feeder
index 5760c751633483dd6f02fe95fe908ae6876e42c1..401e696d19700dc9836b1f7bcff49e689f8d2219 100755 (executable)
--- a/bin/mpd-feeder
+++ b/bin/mpd-feeder
@@ -113,6 +113,7 @@ class Feeder {
     has $opt :reader;
     has $db;
     has $db_generation;
+    has $db_needs_update = 1;
     has $mpd :reader;
 
 use constant DEFAULT_CONFIG_FILE => '/etc/mpd-feeder/mpd-feeder.conf';
@@ -138,6 +139,8 @@ use Net::Async::MPD;
 
         $opt->parse_command_line;
 
+        $db_needs_update = 0 if $opt->skip_db_update;
+
         Log::Any::Adapter->set( Stderr => log_level => $opt->log_level );
     }
 
@@ -161,7 +164,7 @@ use Net::Async::MPD;
         $log->info( "Connected to database " . $opt->db_path );
         $db_generation = $self->db_get_option('generation');
         $log->debug("DB generation is $db_generation");
-        $self->update_db unless $opt->skip_db_update;
+        $self->update_db;
     }
 
     method db_get_option($name) {
@@ -231,44 +234,48 @@ SQL
         )->execute( $item->{artist}, $item->{album} );
     }
 
-    method update_db() {
+    method update_db($force = undef) {
+        if (!$db_needs_update and !$force) {
+            $log->debug("Skipping DB update");
+            return;
+        }
+
         $log->info('Updating song database');
-        $mpd->send('listallinfo')->on_done(
-            sub {
-                try {
-                    my $rows = shift;
-                    $db->begin_work;
+        $self->connect_mpd;
+        $self->connect_db;
 
-                    $db_generation++;
+        my $rows = $mpd->send('listallinfo')->get;
+        try {
+            $db->begin_work;
 
-                    my $song_count;
+            $db_generation++;
 
-                    foreach my $entry (@$rows) {
-                        next unless exists $entry->{file};
-                        $self->db_store_song( $entry->{file},
-                            $entry->{Artist}, $entry->{Album} );
-                        $song_count++;
-                    }
+            my $song_count;
+
+            foreach my $entry (@$rows) {
+                next unless exists $entry->{file};
+                $self->db_store_song( $entry->{file},
+                    $entry->{Artist}, $entry->{Album} );
+                $song_count++;
+            }
 
-                    $log->info("Updated data about $song_count songs");
+            $log->info("Updated data about $song_count songs");
 
-                    $self->db_remove_stale_entries;
+            $self->db_remove_stale_entries;
 
-                    $self->db_set_option( generation => $db_generation );
+            $self->db_set_option( generation => $db_generation );
 
-                    $db->commit;
-                }
-                catch {
-                    my $err = $@;
+            $db->commit;
+        }
+        catch {
+            my $err = $@;
 
-                    $db_generation--;
+            $db_generation--;
 
-                    $db->rollback;
+            $db->rollback;
 
-                    die $err;
-                }
-            }
-        );
+            die $err;
+        }
     }
 
     method db_find_suitable_songs($num) {
@@ -303,8 +310,8 @@ SQL
     }
 
     method queue_songs($num = undef, $callback = undef) {
-        $self->connect_mpd;
         if (!defined $num) {
+            $self->connect_mpd;
             $mpd->send('playlist')->on_done(
                 sub {
                     my $present = scalar @{ $_[0] };
@@ -350,6 +357,7 @@ SQL
         for (@paths) {
             push @commands, [ add => "\"$_\"" ];
         }
+        $self->connect_mpd;
         my $f = $mpd->send( \@commands );
         warn "here";
         $f->on_fail( sub { die @_ } );
@@ -373,7 +381,7 @@ SQL
                 use JSON; warn to_json($result);
 
                 if ( $result->{changed} eq 'database' ) {
-                    $self->update_db;
+                    $self->update_db(1);
                     $self->prepare_to_wait_idle;
                 }
                 elsif ( $result->{changed} eq 'playlist' ) {