version is mandatory when updating a list

[lsl.git] / lib / App / LazyShoppingList / API / v1.pm

diff --git a/lib/App/LazyShoppingList/API/v1.pm b/lib/App/LazyShoppingList/API/v1.pm
index e48146445eb39926ea9148245f6fb06e1097f331..f65fd42787171a823eb8790de07d6f11efdbb80d 100644 (file)
--- a/lib/App/LazyShoppingList/API/v1.pm
+++ b/lib/App/LazyShoppingList/API/v1.pm
@@ -166,7 +166,8 @@ put '/list/:list_id/:item_id' => sub {
     my $req = request_data;
 
     my $descr = $req->{description};
-    my $done  = JSON->boolean( $req->{done} // 0 );
+    my $done =
+        exists $req->{done} ? JSON->boolean( $req->{done} // 0 ) : undef;
     my $version = $req->{version};
 
     length($version) and $version =~ /^\d{1,18}$/
@@ -221,8 +222,8 @@ put '/list/:list_id' => sub {
 
     my $req = request_data;
 
-    my $name    = $req->{name}    // '';
-    my $version = $req->{version} // -1;
+    my $name    = $req->{name} // '';
+    my $version = $req->{version};
 
     length($version) and $version =~ /^\d{1,18}$/
         or return invalid_input('bad version');
@@ -274,4 +275,36 @@ del '/list/:list_id' => sub {
     return \%r;
 };
 
+# delete shopping list item
+del '/list/:list_id/:item_id' => sub {
+    my $list_id = route_parameters->get('list_id');
+    length($list_id) and $list_id =~ /^\d{1,18}$/
+        or return invalid_input('bad list ID');
+
+    my $item_id = route_parameters->get('item_id');
+    length($item_id) and $item_id =~ /^\d{1,18}$/
+        or return invalid_input('bad item ID');
+
+    my $dbh = get_database;
+
+    my %r = (
+        lists_version => get_lists_version($dbh),
+    );
+
+    my $list = $dbh->resultset('ShoppingList')->find($list_id)
+        or return exception 404, 'No such list';
+
+    my $item = $dbh->resultset('ShoppingListItem')
+        ->find( { shopping_list => $list->id, id => $item_id } );
+
+    if ($item) {
+        $item->delete;
+        $list->update({version => $list->version + 1});
+    }
+
+    $r{list_version} = $list->version;
+
+    return \%r;
+};
+
 true;