]> git.ktnx.net Git - mpd-feeder.git/blobdiff - lib/App/MPD/Feeder.pm
periodically break out of idle mode to see if the connection to MPD is intact
[mpd-feeder.git] / lib / App / MPD / Feeder.pm
index 4285e7077549ce294e26b6c7b6d75babef7f9da3..2ce166f6a4b45e1a4a5534534af2a474eafe2bd9 100644 (file)
@@ -3,12 +3,15 @@ package App::MPD::Feeder;
 use strict;
 use warnings;
 use utf8;
+use feature 'state';
 
 use App::MPD::Feeder::Options;
+use App::MPD::Feeder::DB;
 use DBD::Pg;
 use DBI;
 use Getopt::Long;
 use IO::Async::Signal;
+use IO::Async::Timer::Periodic;
 use Log::Any qw($log);
 use Net::Async::MPD;
 use Object::Pad;
@@ -18,10 +21,10 @@ use Syntax::Keyword::Try;
 class App::MPD::Feeder {
     has $cfg_file :reader;
     has $opt :reader;
-    has $db;
-    has $db_generation;
+    has $db :reader;
     has $db_needs_update :writer = 1;
     has $mpd :reader;
+    has $idler;
 
 use constant DEFAULT_CONFIG_FILE => '/etc/mpd-feeder/mpd-feeder.conf';
 
@@ -47,6 +50,8 @@ use constant DEFAULT_CONFIG_FILE => '/etc/mpd-feeder/mpd-feeder.conf';
         Log::Any::Adapter->set( Stderr => log_level => $new_opt->log_level );
 
         $opt = $new_opt;
+
+        $db = App::MPD::Feeder::DB->new( opt => $opt );
     }
 
     method connect_mpd {
@@ -58,11 +63,39 @@ use constant DEFAULT_CONFIG_FILE => '/etc/mpd-feeder/mpd-feeder.conf';
 
         $mpd = Net::Async::MPD->new(%conn);
 
+        $mpd->on(
+            close => sub {
+                die "Connection to MPD lost";
+            }
+        );
+
+        my $int_signal_handler = sub {
+            state $signal_count = 0;
+            $signal_count++;
+            $log->debug("Signal received. Stopping loop");
+            $mpd->loop->stop('quit');
+
+            if ( $signal_count > 1 ) {
+                $log->warn("Another signal received (#$signal_count)");
+                $log->warn("Exiting abruptly");
+                exit 2;
+            }
+        };
+
+        for (qw(TERM INT)) {
+            $mpd->loop->add(
+                IO::Async::Signal->new(
+                    name       => $_,
+                    on_receipt => $int_signal_handler,
+                )
+            );
+        }
+
         $mpd->loop->add(
             IO::Async::Signal->new(
                 name       => 'HUP',
                 on_receipt => sub {
-                    $log->debug("SIGHUP received. Stopping loop");
+                    $log->debug("SIGHUP received. Scheduling reload");
                     $mpd->loop->stop('reload');
                 },
             )
@@ -86,87 +119,10 @@ use constant DEFAULT_CONFIG_FILE => '/etc/mpd-feeder/mpd-feeder.conf';
     }
 
     method connect_db {
-        return if $db;
-
-        $db = DBI->connect( "dbi:Pg:dbname=" . $opt->db_path,
-            $opt->db_user, $opt->db_password,
-            { RaiseError => 1, PrintError => 0, AutoCommit => 1 } );
-
-        $log->info( "Connected to database " . $opt->db_path );
-        $db_generation = $self->db_get_option('generation');
-        $log->debug("DB generation is $db_generation");
+        $db->connect($opt);
         $self->update_db;
     }
 
-    method db_get_option($name) {
-        my $sth = $db->prepare_cached("select $name from options");
-        $sth->execute;
-        my @result = $sth->fetchrow_array;
-        $sth->finish;
-        undef $sth;
-
-        return $result[0];
-    }
-
-    method db_set_option( $name, $value ) {
-        my $sth = $db->prepare_cached("update options set $name = ?");
-        $sth->execute($value);
-    }
-
-    method db_store_song($song, $artist, $album) {
-        return unless length($song) and length($artist) and length($album);
-
-        $db->prepare_cached(
-            <<'SQL')->execute( $song, $artist, $album, $db_generation );
-INSERT INTO songs(path, artist, album, generation)
-VALUES($1, $2, $3, $4)
-ON CONFLICT ON CONSTRAINT songs_pkey DO
-UPDATE SET artist = $2
-         , album = $3
-         , generation = $4
-SQL
-        $db->prepare_cached(<<'SQL')->execute( $artist, $album, $db_generation );
-INSERT INTO albums(artist, album, generation)
-VALUES($1, $2, $3)
-ON CONFLICT ON CONSTRAINT albums_pkey DO
-UPDATE SET generation = $3
-SQL
-        $db->prepare_cached(<<'SQL')->execute( $artist, $db_generation );
-INSERT INTO artists(artist, generation)
-VALUES($1, $2)
-ON CONFLICT ON CONSTRAINT artists_pkey DO
-UPDATE SET generation = $2
-SQL
-    }
-
-    method db_remove_stale_entries {
-        my $sth =
-            $db->prepare_cached('DELETE FROM songs WHERE generation <> ?');
-        $sth->execute($db_generation);
-        $log->debug( sprintf( "Deleted %d stale songs", $sth->rows ) );
-
-        $sth = $db->prepare_cached('DELETE FROM albums WHERE generation <> ?');
-        $sth->execute($db_generation);
-        $log->debug( sprintf( "Deleted %d stale albums", $sth->rows ) );
-
-        $sth =
-            $db->prepare_cached('DELETE FROM artists WHERE generation <> ?');
-        $sth->execute($db_generation);
-        $log->debug( sprintf( "Deleted %d stale artists", $sth->rows ) );
-    }
-
-    method db_note_song_qeued($item) {
-        $db->prepare_cached(
-            'UPDATE songs SET last_queued=current_timestamp WHERE path=?')
-            ->execute( $item->{song} );
-        $db->prepare_cached(
-            'UPDATE artists SET last_queued=CURRENT_TIMESTAMP WHERE artist=?')
-            ->execute( $item->{artist} );
-        $db->prepare_cached(
-            'UPDATE albums SET last_queued=CURRENT_TIMESTAMP WHERE artist=? AND album=?'
-        )->execute( $item->{artist}, $item->{album} );
-    }
-
     method update_db($force = undef) {
         if (!$db_needs_update and !$force) {
             $log->debug("Skipping DB update");
@@ -175,207 +131,52 @@ SQL
 
         $log->info('Updating song database');
         $self->connect_mpd;
-        $self->connect_db;
 
         my $rows = $mpd->send('listallinfo')->get;
-        try {
-            $db->begin_work;
 
-            $db_generation++;
+        $log->trace('got all songs from MPD');
 
+        $db->start_update;
+        try {
             my $song_count;
 
             foreach my $entry (@$rows) {
                 next unless exists $entry->{file};
-                $self->db_store_song( $entry->{file},
+
+                $self->db->store_song( $entry->{file},
                     $entry->{AlbumArtist} // $entry->{Artist},
                     $entry->{Album} );
+
                 $song_count++;
             }
 
-            $log->info("Updated data about $song_count songs");
+            my ($total_songs, $total_artists, $total_albums,
+                $new_songs,   $new_artists,   $new_albums
+            ) = $self->db->finish_update;
 
-            $self->db_remove_stale_entries;
-
-            $self->db_set_option( generation => $db_generation );
-
-            $db->commit;
-
-            $db_needs_update = 0;
-        }
-        catch {
-            my $err = $@;
+            $log->info(
+                "Updated data about $song_count songs (including $new_songs new), "
+                    . "$total_artists artists (including $new_artists new) "
 
-            $db_generation--;
-
-            $db->rollback;
-
-            die $err;
-        }
-    }
-
-    method db_find_suitable_songs($num) {
-        $self->connect_db;
-        $self->update_db;
-
-        my @result;
-        my $sql = <<SQL;
-SELECT s.path, s.artist, s.album
-FROM songs s
-JOIN artists ar ON ar.artist=s.artist
-JOIN albums al ON al.album=s.album AND al.artist=s.artist
-WHERE (s.last_queued IS NULL OR s.last_queued < CURRENT_TIMESTAMP - (? || ' seconds')::interval)
-  AND (ar.last_queued IS NULL OR ar.last_queued < CURRENT_TIMESTAMP - (? || ' seconds')::interval)
-  AND (al.last_queued IS NULL OR al.last_queued < CURRENT_TIMESTAMP - (? || ' seconds')::interval)
-  AND NOT EXISTS (SELECT 1 FROM unwanted_artists uar WHERE uar.artist = s.artist)
-  AND NOT EXISTS (SELECT 1 FROM unwanted_albums  ual WHERE ual.album  = s.album)
-ORDER BY random()
-LIMIT ?
-SQL
-        my @params = (
-            $opt->min_song_interval,  $opt->min_artist_interval,
-            $opt->min_album_interval, $num,
-        );
-        my $sth = $db->prepare_cached($sql);
-        $sth->execute(@params);
-        while ( my @row = $sth->fetchrow_array ) {
-            push @result,
-                { song => $row[0], artist => $row[1], album => $row[2] };
-        }
-        undef $sth;
-
-        if (scalar(@result) == $num and  $log->is_debug) {
-            $sql =~ s/^SELECT .+$/SELECT COUNT(DISTINCT s.path)/m;
-            $sql =~ s/^ORDER BY .+$//m;
-            $sql =~ s/^LIMIT .+$//m;
-            $log->debug($sql);
-            my $sth = $db->prepare_cached($sql);
-            pop @params;
-            $sth->execute(@params);
-            my $count = ($sth->fetchrow_array)[0];
-            $sth->finish;
-
-            $sth = $db->prepare_cached('SELECT COUNT(*) FROM songs');
-            $sth->execute;
-            my $total = ($sth->fetchrow_array)[0];
-            $log->debug(
-                sprintf(
-                    "Number of songs meeting the criteria: %d out of total %d (%5.2f%%)",
-                    $count, $total, 100.0 * $count / $total
-                )
+                    . "and $total_albums albums (including $new_albums new)"
             );
-            $sth->finish;
-
-            $sql = <<SQL;
-SELECT COUNT(*)
-FROM songs s
-WHERE (s.last_queued IS NULL OR s.last_queued < CURRENT_TIMESTAMP - (? || ' seconds')::interval)
-UNION
-SELECT COUNT(*)
-FROM songs
-SQL
-            $sth = $db->prepare_cached($sql);
-            $sth->execute($opt->min_song_interval);
-            $count = ($sth->fetchrow_array)[0];
-            $total = ($sth->fetchrow_array)[0];
-            $sth->finish;
-
-            $log->debug(
-                sprintf(
-                    "Number of songs not queued soon: %d out of total %d (%5.2f%%)",
-                    $count, $total, 100.0 * $count / $total
-                )
-            );
-            $sth->finish;
-
-            $sql = <<SQL;
-SELECT COUNT(*)
-FROM artists ar
-WHERE (ar.last_queued IS NULL OR ar.last_queued < CURRENT_TIMESTAMP - (? || ' seconds')::interval)
-UNION
-SELECT COUNT(*)
-FROM artists
-SQL
-            $sth = $db->prepare_cached($sql);
-            $sth->execute($opt->min_artist_interval);
-            $count = ($sth->fetchrow_array)[0];
-            $total = ($sth->fetchrow_array)[0];
-            $log->debug(
-                sprintf(
-                    "Number of artists not queued soon: %d out of total %d (%5.2f%%)",
-                    $count, $total, 100.0 * $count / $total
-                )
-            );
-            $sth->finish;
-
-            $sql = <<SQL;
-SELECT COUNT(*)
-FROM albums al
-WHERE (al.last_queued IS NULL OR al.last_queued < CURRENT_TIMESTAMP - (? || ' seconds')::interval)
-UNION
-SELECT COUNT(*)
-FROM albums
-SQL
-            $sth = $db->prepare_cached($sql);
-            $sth->execute($opt->min_album_interval);
-            $count = ($sth->fetchrow_array)[0];
-            $total = ($sth->fetchrow_array)[0];
-            $log->debug(
-                sprintf(
-                    "Number of albums not queued soon: %d out of total %d (%5.2f%%)",
-                    $count, $total, 100.0 * $count / $total
-                )
-            );
-            $sth->finish;
-
-            undef $sth;
-        }
 
-        return @result;
-    }
-
-    method db_add_unwanted_artist($artist) {
-        $self->connect_db;
-
-        try {
-            $db->do(
-                <<'SQL',
-INSERT INTO unwanted_artists(artist, generation)
-VALUES($1, $2)
-SQL
-                undef, $artist, $db_generation
-            );
-            return 1;
+            $db_needs_update = 0;
         }
         catch {
             my $err = $@;
-
-            $log->debug("PostgreSQL error: $err");
-            $log->debug( "SQLSTATE = " . $db->state );
-            return 0 if $db->state eq '23505';
-
+            $self->db->cancel_update;
             die $err;
         }
     }
 
-    method db_del_unwanted_artist($artist) {
-        $self->connect_db;
-
-        return 1 == $db->do(
-            <<'SQL',
-DELETE FROM unwanted_artists
-WHERE artist = $1
-SQL
-            undef, $artist
-        );
-    }
-
     method queue_songs($num = undef, $callback = undef) {
+        $self->connect_db;
         if (!defined $num) {
             $self->connect_mpd;
             $mpd->send('playlist')->on_done(
                 sub {
-                    my $present = scalar @{ $_[0] };
+                    my $present = scalar @{ $_[0] // [] };
 
                     $log->notice( "Playlist contains $present songs. Wanted: "
                             . $opt->target_queue_length );
@@ -392,7 +193,7 @@ SQL
             return;
         }
 
-        my @list = $self->db_find_suitable_songs($num);
+        my @list = $self->db->find_suitable_songs($num);
 
         die "Found no suitable songs" unless @list;
 
@@ -415,6 +216,8 @@ SQL
         }
 
         $log->debug( "Adding " . join( ', ', map {"«$_»"} @paths ) );
+        # MPD needs raw bytes
+        utf8::encode($_) for @paths;
         my @commands;
         for (@paths) {
             push @commands, [ add => "\"$_\"" ];
@@ -424,7 +227,7 @@ SQL
         $f->on_fail( sub { die @_ } );
         $f->on_done(
             sub {
-                $self->db_note_song_qeued($_) for @list;
+                $self->db->note_song_qeued($_) for @list;
                 $callback->(@_) if $callback;
             }
         );
@@ -432,18 +235,26 @@ SQL
 
     method prepare_to_wait_idle {
         $log->trace('declaring idle mode');
-        $mpd->send('idle database playlist')->on_done(
+        $idler = $mpd->send('idle database playlist')->on_done(
             sub {
                 my $result = shift;
 
-                if ( $result->{changed} eq 'database' ) {
+                undef $idler;
+
+                my $changed = $result->{changed} // '';
+
+                if ( $changed eq 'database' ) {
                     $db_needs_update = 1;
                     $self->prepare_to_wait_idle;
                 }
-                elsif ( $result->{changed} eq 'playlist' ) {
+                elsif ( $changed eq 'playlist' ) {
                     $self->queue_songs( undef,
                         sub { $self->prepare_to_wait_idle } );
                 }
+                elsif ( $changed eq '' ) {
+                    $log->debug("got no changes from idle");
+                    $self->prepare_to_wait_idle;
+                }
                 else {
                     use JSON;
                     $log->warn(
@@ -454,40 +265,32 @@ SQL
         );
     }
 
-    method run {
-        $mpd->on(
-            close => sub {
-                die "Connection to MPD lost";
-            }
-        );
-
-        $self->prepare_to_wait_idle;
-    }
-
     method stop {
         undef $mpd;
 
-        if ($db) {
-            if ($db->{ActiveKids}) {
-                $log->warn("$db->{ActiveKids} active DB statements");
-                for my $st ( @{ $db->{ChildHandles} } ) {
-                    next unless $st->{Active};
-                    while(my($k,$v) = each %$st) {
-                        $log->debug("$k = ".($v//'<NULL>'));
-                    }
-                }
-            }
-
-            $db->disconnect;
-            undef $db;
-        }
+        $db->disconnect;
     }
 
     method run_loop {
+        $self->connect_mpd;
         $self->connect_db;
 
+        $mpd->loop->add(
+            IO::Async::Timer::Periodic->new(
+                interval => 300,
+                on_tick  => sub {
+                    if ($idler) {
+                        $log->trace('breaking idle to see if MPD is there');
+                        undef $idler;
+                        $log->trace("> noidle (direct)");
+                        $mpd->{mpd_handle}->write("noidle\n");
+                    }
+                },
+            )->start
+        );
+
         for ( ;; ) {
-            $self->queue_songs( undef, sub { $self->run } );
+            $self->queue_songs( undef, sub { $self->prepare_to_wait_idle } );
 
             $log->debug("Entering event loop. PID=$$");
 
@@ -498,7 +301,18 @@ SQL
                 $log->notice("disconnecting");
                 $self->stop;
 
-                exec( "$0", '--config', $self->cfg_file, '--skip-db-update' );
+                my @exec = ( $0, '--config', $self->cfg_file, '--skip-db-update' );
+                if ( $log->is_trace ) {
+                    $log->trace( 'exec '
+                            . join( ' ', map { /\s/ ? "'$_'" : $_ } @exec ) );
+                }
+                exec(@exec);
+            }
+
+            if ( 'quit' eq $result ) {
+                $log->trace("quitting because of 'quit' loop result");
+                $self->stop;
+                exit 0;
             }
         }
     }