]> git.ktnx.net Git - mobile-ledger.git/commitdiff
fix crash in version checking code with two-component versions (3.14)
authorDamyan Ivanov <dam+mobileledger@ktnx.net>
Sun, 23 May 2021 14:36:36 +0000 (17:36 +0300)
committerDamyan Ivanov <dam+mobileledger@ktnx.net>
Sun, 23 May 2021 14:36:36 +0000 (17:36 +0300)
app/src/main/java/net/ktnx/mobileledger/ui/profiles/ProfileDetailModel.java

index 2460b2e0938eb8855e1e9b000679bd819b55daec..09b0a067a66256b30565fa90191b870505445915 100644 (file)
@@ -338,8 +338,9 @@ public class ProfileDetailModel extends ViewModel {
                 if (m.matches()) {
                     int major = Integer.parseInt(Objects.requireNonNull(m.group(1)));
                     int minor = Integer.parseInt(Objects.requireNonNull(m.group(2)));
-                    final boolean hasPatch = m.groupCount() >= 3;
-                    int patch = hasPatch ? Integer.parseInt(Objects.requireNonNull(m.group(3))) : 0;
+                    final String patchText = m.group(3);
+                    final boolean hasPatch = patchText != null;
+                    int patch = hasPatch ? Integer.parseInt(patchText) : 0;
 
                     return hasPatch ? new HledgerVersion(major, minor, patch)
                                     : new HledgerVersion(major, minor);