From fbaaba448b36e6f43d357c7651acef6746670f6e Mon Sep 17 00:00:00 2001 From: Damyan Ivanov Date: Sun, 17 May 2020 19:11:50 +0300 Subject: [PATCH] fix theming huge benefit: follow system font settings --- .../net/ktnx/mobileledger/utils/Colors.java | 74 +++--- app/src/main/res/values/styles.xml | 240 ++++++------------ tools/gen-styles | 5 +- 3 files changed, 117 insertions(+), 202 deletions(-) diff --git a/app/src/main/java/net/ktnx/mobileledger/utils/Colors.java b/app/src/main/java/net/ktnx/mobileledger/utils/Colors.java index 8049d76b..1316a8e5 100644 --- a/app/src/main/java/net/ktnx/mobileledger/utils/Colors.java +++ b/app/src/main/java/net/ktnx/mobileledger/utils/Colors.java @@ -59,42 +59,42 @@ public class Colors { public static MutableLiveData themeWatch = new MutableLiveData<>(0); public static int errorTextColor; private static int[] themeIDs = - {R.style.AppTheme_NoActionBar_000, R.style.AppTheme_NoActionBar_005, - R.style.AppTheme_NoActionBar_010, R.style.AppTheme_NoActionBar_015, - R.style.AppTheme_NoActionBar_020, R.style.AppTheme_NoActionBar_025, - R.style.AppTheme_NoActionBar_030, R.style.AppTheme_NoActionBar_035, - R.style.AppTheme_NoActionBar_040, R.style.AppTheme_NoActionBar_045, - R.style.AppTheme_NoActionBar_050, R.style.AppTheme_NoActionBar_055, - R.style.AppTheme_NoActionBar_060, R.style.AppTheme_NoActionBar_065, - R.style.AppTheme_NoActionBar_070, R.style.AppTheme_NoActionBar_075, - R.style.AppTheme_NoActionBar_080, R.style.AppTheme_NoActionBar_085, - R.style.AppTheme_NoActionBar_090, R.style.AppTheme_NoActionBar_095, - R.style.AppTheme_NoActionBar_100, R.style.AppTheme_NoActionBar_105, - R.style.AppTheme_NoActionBar_110, R.style.AppTheme_NoActionBar_115, - R.style.AppTheme_NoActionBar_120, R.style.AppTheme_NoActionBar_125, - R.style.AppTheme_NoActionBar_130, R.style.AppTheme_NoActionBar_135, - R.style.AppTheme_NoActionBar_140, R.style.AppTheme_NoActionBar_145, - R.style.AppTheme_NoActionBar_150, R.style.AppTheme_NoActionBar_155, - R.style.AppTheme_NoActionBar_160, R.style.AppTheme_NoActionBar_165, - R.style.AppTheme_NoActionBar_170, R.style.AppTheme_NoActionBar_175, - R.style.AppTheme_NoActionBar_180, R.style.AppTheme_NoActionBar_185, - R.style.AppTheme_NoActionBar_190, R.style.AppTheme_NoActionBar_195, - R.style.AppTheme_NoActionBar_200, R.style.AppTheme_NoActionBar_205, - R.style.AppTheme_NoActionBar_210, R.style.AppTheme_NoActionBar_215, - R.style.AppTheme_NoActionBar_220, R.style.AppTheme_NoActionBar_225, - R.style.AppTheme_NoActionBar_230, R.style.AppTheme_NoActionBar_235, - R.style.AppTheme_NoActionBar_240, R.style.AppTheme_NoActionBar_245, - R.style.AppTheme_NoActionBar_250, R.style.AppTheme_NoActionBar_255, - R.style.AppTheme_NoActionBar_260, R.style.AppTheme_NoActionBar_265, - R.style.AppTheme_NoActionBar_270, R.style.AppTheme_NoActionBar_275, - R.style.AppTheme_NoActionBar_280, R.style.AppTheme_NoActionBar_285, - R.style.AppTheme_NoActionBar_290, R.style.AppTheme_NoActionBar_295, - R.style.AppTheme_NoActionBar_300, R.style.AppTheme_NoActionBar_305, - R.style.AppTheme_NoActionBar_310, R.style.AppTheme_NoActionBar_315, - R.style.AppTheme_NoActionBar_320, R.style.AppTheme_NoActionBar_325, - R.style.AppTheme_NoActionBar_330, R.style.AppTheme_NoActionBar_335, - R.style.AppTheme_NoActionBar_340, R.style.AppTheme_NoActionBar_345, - R.style.AppTheme_NoActionBar_350, R.style.AppTheme_NoActionBar_355, + {R.style.AppTheme_000, R.style.AppTheme_005, + R.style.AppTheme_010, R.style.AppTheme_015, + R.style.AppTheme_020, R.style.AppTheme_025, + R.style.AppTheme_030, R.style.AppTheme_035, + R.style.AppTheme_040, R.style.AppTheme_045, + R.style.AppTheme_050, R.style.AppTheme_055, + R.style.AppTheme_060, R.style.AppTheme_065, + R.style.AppTheme_070, R.style.AppTheme_075, + R.style.AppTheme_080, R.style.AppTheme_085, + R.style.AppTheme_090, R.style.AppTheme_095, + R.style.AppTheme_100, R.style.AppTheme_105, + R.style.AppTheme_110, R.style.AppTheme_115, + R.style.AppTheme_120, R.style.AppTheme_125, + R.style.AppTheme_130, R.style.AppTheme_135, + R.style.AppTheme_140, R.style.AppTheme_145, + R.style.AppTheme_150, R.style.AppTheme_155, + R.style.AppTheme_160, R.style.AppTheme_165, + R.style.AppTheme_170, R.style.AppTheme_175, + R.style.AppTheme_180, R.style.AppTheme_185, + R.style.AppTheme_190, R.style.AppTheme_195, + R.style.AppTheme_200, R.style.AppTheme_205, + R.style.AppTheme_210, R.style.AppTheme_215, + R.style.AppTheme_220, R.style.AppTheme_225, + R.style.AppTheme_230, R.style.AppTheme_235, + R.style.AppTheme_240, R.style.AppTheme_245, + R.style.AppTheme_250, R.style.AppTheme_255, + R.style.AppTheme_260, R.style.AppTheme_265, + R.style.AppTheme_270, R.style.AppTheme_275, + R.style.AppTheme_280, R.style.AppTheme_285, + R.style.AppTheme_290, R.style.AppTheme_295, + R.style.AppTheme_300, R.style.AppTheme_305, + R.style.AppTheme_310, R.style.AppTheme_315, + R.style.AppTheme_320, R.style.AppTheme_325, + R.style.AppTheme_330, R.style.AppTheme_335, + R.style.AppTheme_340, R.style.AppTheme_345, + R.style.AppTheme_350, R.style.AppTheme_355, }; public static void refreshColors(Resources.Theme theme) { TypedValue tv = new TypedValue(); @@ -216,7 +216,7 @@ public class Colors { } if (themeId < 0) { - themeId = R.style.AppTheme_NoActionBar; + themeId = R.style.AppTheme; debug("profiles", String.format(Locale.ENGLISH, "Theme hue %d not supported, using the default", themeHue)); diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 71cb42c2..cf076fb1 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -17,678 +17,596 @@ + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/tools/gen-styles b/tools/gen-styles index 9191e18a..0b8759c2 100644 --- a/tools/gen-styles +++ b/tools/gen-styles @@ -138,7 +138,7 @@ for (my $s = 0.50; $s < 0.90; $s += 0.001) { warn sprintf( 's%1.3f, l%1.3f -> %s', @$best ); -my $baseTheme = "AppTheme.NoActionBar"; +my $baseTheme = "AppTheme"; use constant STEP_DEGREES => 5; @@ -152,7 +152,6 @@ use constant STEP_DEGREES => 5; # hsvHex($hue/360.0, 0.86, 0.55); # printf " #%s\n", # hsvHex(($hue-4)/360.0, 0.72, 0.82); -# printf " #ffffffff\n"; # printf " #28%s\n", # hsvHex($hue/360.0, 0.65, 0.83); # printf " #28%s\n", @@ -166,7 +165,6 @@ use constant STEP_DEGREES => 5; sub outputThemes { my $out = shift; my $baseIndent = shift; - $out->print(hslStyleForHue($baseColorHue, undef, $baseIndent)); for( my $hue = 0; $hue < 360; $hue += STEP_DEGREES ) { $out->print("\n"); $out->print(hslStyleForHue($hue, $baseTheme, $baseIndent)); @@ -222,7 +220,6 @@ sub hslStyleForHue { hslHex($hue, $S, $l1); $result .= sprintf "$indent#%s\n", hslHex($hue, $S, $l2); - $result .= "$indent#ffffffff\n"; $result .= sprintf "$indent#%s\n", hslHex($hue, $S, $l3); $result .= sprintf "$indent#%s\n", -- 2.39.5