From ec8e98c8095ed1368ae8b35c8b8ef6e59b9bcb2f Mon Sep 17 00:00:00 2001 From: Damyan Ivanov Date: Sun, 10 Nov 2019 19:39:09 +0200 Subject: [PATCH] make soft keyboard appear when new transaction description/account gets focus this is used when the focus is given artificially, when date is picked (and focus goes to the transaction description) and when a transaction description is selected from the drop down (and focus goes to the first account name) --- .../ui/activity/NewTransactionItemHolder.java | 27 ++++++++++--------- .../net/ktnx/mobileledger/utils/Misc.java | 16 +++++++++++ 2 files changed, 31 insertions(+), 12 deletions(-) diff --git a/app/src/main/java/net/ktnx/mobileledger/ui/activity/NewTransactionItemHolder.java b/app/src/main/java/net/ktnx/mobileledger/ui/activity/NewTransactionItemHolder.java index 4bf75d00..81487af6 100644 --- a/app/src/main/java/net/ktnx/mobileledger/ui/activity/NewTransactionItemHolder.java +++ b/app/src/main/java/net/ktnx/mobileledger/ui/activity/NewTransactionItemHolder.java @@ -17,12 +17,10 @@ package net.ktnx.mobileledger.ui.activity; -import android.content.Context; import android.text.Editable; import android.text.TextWatcher; import android.view.View; import android.view.inputmethod.EditorInfo; -import android.view.inputmethod.InputMethodManager; import android.widget.AutoCompleteTextView; import android.widget.FrameLayout; import android.widget.LinearLayout; @@ -41,6 +39,7 @@ import net.ktnx.mobileledger.model.MobileLedgerProfile; import net.ktnx.mobileledger.ui.DatePickerFragment; import net.ktnx.mobileledger.utils.Logger; import net.ktnx.mobileledger.utils.MLDB; +import net.ktnx.mobileledger.utils.Misc; import java.util.Calendar; import java.util.Date; @@ -153,11 +152,20 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder if ((index != null) && index.equals(getAdapterPosition())) { switch (item.getType()) { case generalData: - tvDate.requestFocus(); + // bad idea - double pop-up, and not really necessary. + // the user can tap the input to get the calendar + //if (!tvDate.hasFocus()) tvDate.requestFocus(); + boolean focused = tvDescription.requestFocus(); + tvDescription.dismissDropDown(); + if (focused) Misc.showSoftKeyboard( + (NewTransactionActivity) tvDescription.getContext()); break; case transactionRow: - tvAccount.requestFocus(); + focused = tvAccount.requestFocus(); tvAccount.dismissDropDown(); + if (focused) + Misc.showSoftKeyboard((NewTransactionActivity) tvAccount.getContext()); + break; } } @@ -291,14 +299,9 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder final Calendar c = GregorianCalendar.getInstance(); c.set(year, month, day); item.setDate(c.getTime()); - boolean tookFocus = tvDescription.requestFocus(); - if (tookFocus) { - // make the keyboard appear - InputMethodManager imm = (InputMethodManager) tvDate.getContext() - .getSystemService( - Context.INPUT_METHOD_SERVICE); - imm.toggleSoftInput(InputMethodManager.SHOW_IMPLICIT, 0); - } + boolean focused = tvDescription.requestFocus(); + if (focused) Misc.showSoftKeyboard((NewTransactionActivity) tvAccount.getContext()); + } @Override public void descriptionSelected(String description) { diff --git a/app/src/main/java/net/ktnx/mobileledger/utils/Misc.java b/app/src/main/java/net/ktnx/mobileledger/utils/Misc.java index ee6f5a74..3fae49f1 100644 --- a/app/src/main/java/net/ktnx/mobileledger/utils/Misc.java +++ b/app/src/main/java/net/ktnx/mobileledger/utils/Misc.java @@ -17,8 +17,24 @@ package net.ktnx.mobileledger.utils; +import android.app.Activity; +import android.view.WindowManager; + +import androidx.fragment.app.Fragment; + public class Misc { public static boolean isZero(float f) { return (f < 0.005) && (f > -0.005); } + public static void showSoftKeyboard(Activity activity) { + // make the keyboard appear + activity.getWindow() + .setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_STATE_ALWAYS_VISIBLE); + } + public static void showSoftKeyboard(Fragment fragment) { + // make the keyboard appear + fragment.getActivity() + .getWindow() + .setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_STATE_ALWAYS_VISIBLE); + } } -- 2.39.2