remove context parameter from MLDB.getWritableDB

[mobile-ledger.git] / app / src / main / java / net / ktnx / mobileledger / utils / MLDB.java

diff --git a/app/src/main/java/net/ktnx/mobileledger/utils/MLDB.java b/app/src/main/java/net/ktnx/mobileledger/utils/MLDB.java
index d528a37a9ccb9e17dba0c20f21ec3c32abc910c3..c11ea8486182839e89c3667ee23d5acc82e1aea8 100644 (file)
--- a/app/src/main/java/net/ktnx/mobileledger/utils/MLDB.java
+++ b/app/src/main/java/net/ktnx/mobileledger/utils/MLDB.java
@@ -1,5 +1,5 @@
 /*
- * Copyright © 2018 Damyan Ivanov.
+ * Copyright © 2019 Damyan Ivanov.
  * This file is part of Mobile-Ledger.
  * Mobile-Ledger is free software: you can distribute it and/or modify it
  * under the term of the GNU General Public License as published by
@@ -42,14 +42,18 @@ import static net.ktnx.mobileledger.utils.MLDB.DatabaseMode.READ;
 import static net.ktnx.mobileledger.utils.MLDB.DatabaseMode.WRITE;
 
 public final class MLDB {
-    public enum DatabaseMode {READ, WRITE}
-
     public static final String ACCOUNTS_TABLE = "accounts";
     public static final String DESCRIPTION_HISTORY_TABLE = "description_history";
     public static final String OPT_TRANSACTION_LIST_STAMP = "transaction_list_last_update";
     private static MobileLedgerDatabase helperForReading, helperForWriting;
+    private static Context context;
+    private static void checkState() {
+        if (context == null)
+            throw new IllegalStateException("First call init with a valid context");
+    }
+    public static synchronized SQLiteDatabase getDatabase(DatabaseMode mode) {
+        checkState();
 
-    public static synchronized SQLiteDatabase getDatabase(Context context, DatabaseMode mode) {
         if (mode == READ) {
             if (helperForReading == null) helperForReading = new MobileLedgerDatabase(context);
             return helperForReading.getReadableDatabase();
@@ -59,14 +63,14 @@ public final class MLDB {
             return helperForWriting.getWritableDatabase();
         }
     }
-    public static SQLiteDatabase getReadableDatabase(Context context) {
-        return getDatabase(context.getApplicationContext(), READ);
+    public static SQLiteDatabase getReadableDatabase() {
+        return getDatabase(READ);
     }
-    public static SQLiteDatabase getWritableDatabase(Context context) {
-        return getDatabase(context.getApplicationContext(), WRITE);
+    public static SQLiteDatabase getWritableDatabase() {
+        return getDatabase(WRITE);
     }
-    static public int get_option_value(Context context, String name, int default_value) {
-        String s = get_option_value(context, name, String.valueOf(default_value));
+    static public int get_option_value(String name, int default_value) {
+        String s = get_option_value(name, String.valueOf(default_value));
         try {
             return Integer.parseInt(s);
         }
@@ -75,9 +79,8 @@ public final class MLDB {
             return default_value;
         }
     }
-
-    static public long get_option_value(Context context, String name, long default_value) {
-        String s = get_option_value(context, name, String.valueOf(default_value));
+    static public long get_option_value(String name, long default_value) {
+        String s = get_option_value(name, String.valueOf(default_value));
         try {
             return Long.parseLong(s);
         }
@@ -86,10 +89,9 @@ public final class MLDB {
             return default_value;
         }
     }
-
-    static public String get_option_value(Context context, String name, String default_value) {
+    static public String get_option_value(String name, String default_value) {
         Log.d("db", "about to fetch option " + name);
-        try (SQLiteDatabase db = getReadableDatabase(context)) {
+        try (SQLiteDatabase db = getReadableDatabase()) {
             try (Cursor cursor = db
                     .rawQuery("select value from options where name=?", new String[]{name}))
             {
@@ -109,17 +111,15 @@ public final class MLDB {
             }
         }
     }
-
-    static public void set_option_value(Context context, String name, String value) {
+    static public void set_option_value(String name, String value) {
         Log.d("db", "setting option " + name + "=" + value);
-        try (SQLiteDatabase db = getWritableDatabase(context)) {
+        try (SQLiteDatabase db = getWritableDatabase()) {
             db.execSQL("insert or replace into options(name, value) values(?, ?);",
                     new String[]{name, value});
         }
     }
-
-    static public void set_option_value(Context context, String name, long value) {
-        set_option_value(context, name, String.valueOf(value));
+    static public void set_option_value(String name, long value) {
+        set_option_value(name, String.valueOf(value));
     }
     @TargetApi(Build.VERSION_CODES.N)
     public static void hook_autocompletion_adapter(final Context context,
@@ -142,7 +142,7 @@ public final class MLDB {
                 String[] col_names = {FontsContract.Columns._ID, field};
                 MatrixCursor c = new MatrixCursor(col_names);
 
-                try (SQLiteDatabase db = MLDB.getReadableDatabase(context)) {
+                try (SQLiteDatabase db = MLDB.getReadableDatabase()) {
 
                     try (Cursor matches = db.rawQuery(String.format(
                             "SELECT %s as a, case when %s_upper LIKE ?||'%%' then 1 " +
@@ -171,6 +171,10 @@ public final class MLDB {
 
         view.setAdapter(adapter);
     }
+    public static void init(Context context) {
+        MLDB.context = context.getApplicationContext();
+    }
+    public enum DatabaseMode {READ, WRITE}
 }
 
 class MobileLedgerDatabase extends SQLiteOpenHelper implements AutoCloseable {
@@ -203,8 +207,8 @@ class MobileLedgerDatabase extends SQLiteOpenHelper implements AutoCloseable {
         String rev_file = String.format(Locale.US, "sql_%d", rev_no);
 
         int res_id = rm.getIdentifier(rev_file, "raw", mContext.getPackageName());
-        if (res_id == 0) throw new SQLException(
-                String.format(Locale.US, "No resource for revision %d", rev_no));
+        if (res_id == 0)
+            throw new SQLException(String.format(Locale.US, "No resource for revision %d", rev_no));
         db.beginTransaction();
         try (InputStream res = rm.openRawResource(res_id)) {
             Log.d("db", "Applying revision " + String.valueOf(rev_no));