]> git.ktnx.net Git - mobile-ledger.git/commitdiff
fix hooking profile-specific auto-completion adapter
authorDamyan Ivanov <dam+mobileledger@ktnx.net>
Sun, 5 May 2019 18:44:03 +0000 (21:44 +0300)
committerDamyan Ivanov <dam+mobileledger@ktnx.net>
Sun, 5 May 2019 18:44:03 +0000 (21:44 +0300)
at this point the main profile may not have been loaded yet so don't give it
to the hooking routine, which would instead retrieve the profile when the
auto-completion is triggered, at which point Data.profile must be populated

the other user of these routines, the new transaction activity is also bound
to a profile (either the main one in Data.profile, or another -- if invoced
via app shortcut) so it may pass the profile as a parameter

app/src/main/java/net/ktnx/mobileledger/ui/transaction_list/TransactionListFragment.java
app/src/main/java/net/ktnx/mobileledger/utils/MLDB.java

index 7ebf4e9161a409185475f63dcbff384682329e0e..6340b3e2869f490b7bc6fda5a7e671264b5d0944 100644 (file)
@@ -116,7 +116,7 @@ public class TransactionListFragment extends MobileLedgerListFragment {
         vAccountFilter = mActivity.findViewById(R.id.transaction_list_account_name_filter);
         accNameFilter = mActivity.findViewById(R.id.transaction_filter_account_name);
 
-        MLDB.hookAutocompletionAdapter(mActivity, accNameFilter, "accounts", "name", true);
+        MLDB.hookAutocompletionAdapter(mActivity, accNameFilter, "accounts", "name");
         accNameFilter.setOnItemClickListener((parent, view, position, id) -> {
 //                debug("tmp", "direct onItemClick");
             MatrixCursor mc = (MatrixCursor) parent.getItemAtPosition(position);
index e769be4e8de61ae08491e5e69d42ee7c60a7495f..5741a2e6fb45bf8357b7a8b07d66df3685ba1b62 100644 (file)
@@ -136,10 +136,8 @@ public final class MLDB {
     @TargetApi(Build.VERSION_CODES.N)
     public static void hookAutocompletionAdapter(final Context context,
                                                  final AutoCompleteTextView view,
-                                                 final String table, final String field,
-                                                 final boolean profileSpecific) {
-        hookAutocompletionAdapter(context, view, table, field, profileSpecific, null, null,
-                Data.profile.getValue());
+                                                 final String table, final String field) {
+        hookAutocompletionAdapter(context, view, table, field, true, null, null, null);
     }
     @TargetApi(Build.VERSION_CODES.N)
     public static void hookAutocompletionAdapter(final Context context,
@@ -166,13 +164,15 @@ public final class MLDB {
             String sql;
             String[] params;
             if (profileSpecific) {
+                MobileLedgerProfile p = (profile == null) ? Data.profile.getValue() : profile;
+                if (p == null) throw new AssertionError();
                 sql = String.format("SELECT %s as a, case when %s_upper LIKE ?||'%%' then 1 " +
                                     "WHEN %s_upper LIKE '%%:'||?||'%%' then 2 " +
                                     "WHEN %s_upper LIKE '%% '||?||'%%' then 3 else 9 end " +
                                     "FROM %s " +
                                     "WHERE profile=? AND %s_upper LIKE '%%'||?||'%%' " +
                                     "ORDER BY 2, 1;", field, field, field, field, table, field);
-                params = new String[]{str, str, str, profile.getUuid(), str};
+                params = new String[]{str, str, str, p.getUuid(), str};
             }
             else {
                 sql = String.format("SELECT %s as a, case when %s_upper LIKE ?||'%%' then 1 " +