some code analysys noise

diff --git a/app/src/main/java/net/ktnx/mobileledger/AccountSummary.java b/app/src/main/java/net/ktnx/mobileledger/AccountSummary.java
index dedc1005649fa6872b860029ea3d65c0b9459f62..79c5d709412c13be8a6dc643ea9d95b7bb860e0a 100644 (file)
--- a/app/src/main/java/net/ktnx/mobileledger/AccountSummary.java
+++ b/app/src/main/java/net/ktnx/mobileledger/AccountSummary.java
@@ -139,7 +139,7 @@ public class AccountSummary extends AppCompatActivity {
         // Handle action bar item clicks here. The action bar will
         // automatically handle clicks on the Home/Up button, so long
         // as you specify a parent activity in AndroidManifest.xml.
         // Handle action bar item clicks here. The action bar will
         // automatically handle clicks on the Home/Up button, so long
         // as you specify a parent activity in AndroidManifest.xml.

-        int id = item.getItemId();
+//        int id = item.getItemId();

 
         //noinspection SimplifiableIfStatement
         //if (id == R.id.action_settings) {
 
         //noinspection SimplifiableIfStatement
         //if (id == R.id.action_settings) {

diff --git a/app/src/main/java/net/ktnx/mobileledger/AppCompatPreferenceActivity.java b/app/src/main/java/net/ktnx/mobileledger/AppCompatPreferenceActivity.java
index 5dc341a46c0630b01b0d0ff2e2c87416dcb277d8..2d25180afe1caacf951be71786b7e790f944c3e4 100644 (file)
--- a/app/src/main/java/net/ktnx/mobileledger/AppCompatPreferenceActivity.java
+++ b/app/src/main/java/net/ktnx/mobileledger/AppCompatPreferenceActivity.java
@@ -4,6 +4,7 @@ import android.content.res.Configuration;
 import android.os.Bundle;
 import android.preference.PreferenceActivity;
 import android.support.annotation.LayoutRes;
 import android.os.Bundle;
 import android.preference.PreferenceActivity;
 import android.support.annotation.LayoutRes;

+import android.support.annotation.NonNull;

 import android.support.annotation.Nullable;
 import android.support.v7.app.ActionBar;
 import android.support.v7.app.AppCompatDelegate;
 import android.support.annotation.Nullable;
 import android.support.v7.app.ActionBar;
 import android.support.v7.app.AppCompatDelegate;


@@ -41,6 +42,7 @@ public abstract class AppCompatPreferenceActivity extends PreferenceActivity {
         getDelegate().setSupportActionBar(toolbar);
     }
 
         getDelegate().setSupportActionBar(toolbar);
     }
 

+    @NonNull

     @Override
     public MenuInflater getMenuInflater() {
         return getDelegate().getMenuInflater();
     @Override
     public MenuInflater getMenuInflater() {
         return getDelegate().getMenuInflater();

diff --git a/app/src/main/java/net/ktnx/mobileledger/DatePickerFragment.java b/app/src/main/java/net/ktnx/mobileledger/DatePickerFragment.java
index a30913c091220e69ab1bb7578c8f50e7a66f2fcf..bf674ff74730811ad910af210e87c390e83bf39a 100644 (file)
--- a/app/src/main/java/net/ktnx/mobileledger/DatePickerFragment.java
+++ b/app/src/main/java/net/ktnx/mobileledger/DatePickerFragment.java
@@ -7,7 +7,6 @@ import android.os.Build;
 import android.os.Bundle;
 import android.support.annotation.NonNull;
 import android.support.v7.app.AppCompatDialogFragment;
 import android.os.Bundle;
 import android.support.annotation.NonNull;
 import android.support.v7.app.AppCompatDialogFragment;

-import android.util.Log;

 import android.widget.DatePicker;
 import android.widget.TextView;
 
 import android.widget.DatePicker;
 import android.widget.TextView;
 

diff --git a/app/src/main/java/net/ktnx/mobileledger/LedgerTransaction.java b/app/src/main/java/net/ktnx/mobileledger/LedgerTransaction.java
index 1690b9369dd323bd72ffad6c3a8bef943fb37a51..51716cd1d1676b1c45ae018ae2a13747a6cd1270 100644 (file)
--- a/app/src/main/java/net/ktnx/mobileledger/LedgerTransaction.java
+++ b/app/src/main/java/net/ktnx/mobileledger/LedgerTransaction.java
@@ -12,7 +12,7 @@ class LedgerTransaction {
     LedgerTransaction(String date, String description) {
         this.date = date;
         this.description = description;
     LedgerTransaction(String date, String description) {
         this.date = date;
         this.description = description;

-        this.items = new ArrayList<LedgerTransactionItem>();
+        this.items = new ArrayList<>();

     }
 
     void add_item(LedgerTransactionItem item) {
     }
 
     void add_item(LedgerTransactionItem item) {


@@ -35,7 +35,7 @@ class LedgerTransaction {
         this.description = description;
     }
 
         this.description = description;
     }
 

-    public Iterator<LedgerTransactionItem> getItemsIterator() {
+    Iterator<LedgerTransactionItem> getItemsIterator() {

         return new Iterator<LedgerTransactionItem>() {
             private int pointer = 0;
             @Override
         return new Iterator<LedgerTransactionItem>() {
             private int pointer = 0;
             @Override

diff --git a/app/src/main/java/net/ktnx/mobileledger/UrlEncodedFormData.java b/app/src/main/java/net/ktnx/mobileledger/UrlEncodedFormData.java
index 1e09d2407e3f52d7faeead67eebbc9f7925a9213..b729eefeb99b96f95d18ed08fcc5b4c21943b50f 100644 (file)
--- a/app/src/main/java/net/ktnx/mobileledger/UrlEncodedFormData.java
+++ b/app/src/main/java/net/ktnx/mobileledger/UrlEncodedFormData.java
@@ -12,7 +12,7 @@ class UrlEncodedFormData {
     private List<AbstractMap.SimpleEntry<String,String>> pairs;
 
     UrlEncodedFormData() {
     private List<AbstractMap.SimpleEntry<String,String>> pairs;
 
     UrlEncodedFormData() {

-        pairs = new ArrayList<AbstractMap.SimpleEntry<String, String>>();
+        pairs = new ArrayList<>();

     }
 
     void add_pair(String name, String value) {
     }
 
     void add_pair(String name, String value) {