From 1e09e7f7c9f658c98dc809de328fc04a23802df9 Mon Sep 17 00:00:00 2001
From: Damyan Ivanov <dam+mobileledger@ktnx.net>
Date: Thu, 16 Jul 2020 15:39:44 +0000
Subject: [PATCH] visual enhancements of the account list

equal three-row height for default rows. expands when the amounts
are expanded, but the account name stays at the top
---
 app/src/main/res/layout/account_summary_row.xml | 17 +++++++----------
 app/src/main/res/values-night/styles.xml        |  1 +
 app/src/main/res/values/styles.xml              |  3 +++
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/app/src/main/res/layout/account_summary_row.xml b/app/src/main/res/layout/account_summary_row.xml
index 66a373f9..ab8294f8 100644
--- a/app/src/main/res/layout/account_summary_row.xml
+++ b/app/src/main/res/layout/account_summary_row.xml
@@ -23,14 +23,13 @@
     android:id="@+id/account_summary_row"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
+    android:animateLayoutChanges="true"
     android:longClickable="true"
-    android:minHeight="@dimen/thumb_row_height"
     >
     <androidx.constraintlayout.widget.ConstraintLayout
         android:id="@+id/account_name_layout"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
-        app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintEnd_toStartOf="@+id/account_row_acc_amounts"
         app:layout_constraintHorizontal_chainStyle="spread_inside"
         app:layout_constraintHorizontal_weight="3"
@@ -45,12 +44,11 @@
             android:layout_marginStart="8dp"
             android:gravity="center_vertical"
             android:longClickable="true"
-            android:onClick="onAccountSummaryRowViewClicked"
+            android:minHeight="@dimen/default_account_row_height"
             android:paddingStart="8dp"
-            android:text="AccountNameALongOne"
+            android:text="AccountName"
             android:textAppearance="@android:style/TextAppearance.Material.Medium"
             app:layout_constrainedWidth="true"
-            app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintEnd_toStartOf="@id/account_expander_container"
             app:layout_constraintHorizontal_bias="0.0"
             app:layout_constraintHorizontal_chainStyle="packed"
@@ -63,11 +61,10 @@
 
         <androidx.constraintlayout.widget.ConstraintLayout
             android:id="@+id/account_expander_container"
-            android:layout_width="@dimen/thumb_row_height"
-            android:layout_height="@dimen/thumb_row_height"
+            android:layout_width="@dimen/default_account_row_height"
+            android:layout_height="@dimen/default_account_row_height"
             android:foregroundGravity="center_vertical"
-            android:minHeight="@dimen/thumb_row_height"
-            android:onClick="onAccountSummaryRowViewClicked"
+            android:minHeight="@dimen/default_account_row_height"
             app:layout_constraintBottom_toBottomOf="@id/account_row_acc_name"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintStart_toEndOf="@id/account_row_acc_name"
@@ -82,7 +79,6 @@
                 android:backgroundTint="?colorPrimary"
                 android:clickable="true"
                 android:focusable="true"
-                android:onClick="onAccountSummaryRowViewClicked"
                 app:layout_constraintBottom_toBottomOf="parent"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintStart_toStartOf="parent"
@@ -98,6 +94,7 @@
         android:layout_marginStart="12dp"
         android:layout_marginEnd="8dp"
         android:gravity="center_vertical"
+        android:minHeight="@dimen/default_account_row_height"
         android:onClick="onAccountSummaryRowViewClicked"
         android:text="USD 123,45\n678,90\nIRAUSD -17 000.00"
         android:textAppearance="@style/TextAppearance.AppCompat.Medium"
diff --git a/app/src/main/res/values-night/styles.xml b/app/src/main/res/values-night/styles.xml
index 1b393b60..1b39c9e2 100644
--- a/app/src/main/res/values-night/styles.xml
+++ b/app/src/main/res/values-night/styles.xml
@@ -729,4 +729,5 @@
     </style>
 
     <dimen name="thumb_row_height">48dp</dimen>
+    <dimen name="default_account_row_height">64.2857sp</dimen>
 </resources>
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index a25fb608..5778f7a5 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -726,4 +726,7 @@
     </style>
 
     <dimen name="thumb_row_height">48dp</dimen>
+    <!-- px=rows×73+12-->
+    <!-- sp=px÷3.5 -->
+    <dimen name="default_account_row_height">64.2857sp</dimen>
 </resources>
-- 
2.39.2