From 4cdedb2eecf4b8fa1570eff713db7c0d1b3095f7 Mon Sep 17 00:00:00 2001
From: Damyan Ivanov <dam+mobileledger@ktnx.net>
Date: Mon, 28 Jan 2019 22:01:35 +0200
Subject: [PATCH] replace two literal charset names with pre-defined constants

---
 .../ktnx/mobileledger/async/RetrieveTransactionsTask.java    | 5 +++--
 .../net/ktnx/mobileledger/async/SaveTransactionTask.java     | 3 ++-
 .../main/java/net/ktnx/mobileledger/utils/NetworkUtil.java   | 5 +++--
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/app/src/main/java/net/ktnx/mobileledger/async/RetrieveTransactionsTask.java b/app/src/main/java/net/ktnx/mobileledger/async/RetrieveTransactionsTask.java
index 56a26621..f66da7a8 100644
--- a/app/src/main/java/net/ktnx/mobileledger/async/RetrieveTransactionsTask.java
+++ b/app/src/main/java/net/ktnx/mobileledger/async/RetrieveTransactionsTask.java
@@ -42,6 +42,7 @@ import java.lang.ref.WeakReference;
 import java.net.HttpURLConnection;
 import java.net.MalformedURLException;
 import java.net.URLDecoder;
+import java.nio.charset.StandardCharsets;
 import java.text.ParseException;
 import java.util.ArrayList;
 import java.util.Date;
@@ -131,8 +132,8 @@ public class RetrieveTransactionsTask
 
                         ParserState state = ParserState.EXPECTING_ACCOUNT;
                         String line;
-                        BufferedReader buf =
-                                new BufferedReader(new InputStreamReader(resp, "UTF-8"));
+                        BufferedReader buf = new BufferedReader(
+                                new InputStreamReader(resp, StandardCharsets.UTF_8));
 
                         int processedTransactionCount = 0;
                         int transactionId = 0;
diff --git a/app/src/main/java/net/ktnx/mobileledger/async/SaveTransactionTask.java b/app/src/main/java/net/ktnx/mobileledger/async/SaveTransactionTask.java
index fae87bc3..f23cba32 100644
--- a/app/src/main/java/net/ktnx/mobileledger/async/SaveTransactionTask.java
+++ b/app/src/main/java/net/ktnx/mobileledger/async/SaveTransactionTask.java
@@ -33,6 +33,7 @@ import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.io.OutputStream;
 import java.net.HttpURLConnection;
+import java.nio.charset.StandardCharsets;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
@@ -82,7 +83,7 @@ public class SaveTransactionTask extends AsyncTask<LedgerTransaction, Void, Void
 
         try (OutputStream req = http.getOutputStream()) {
             Log.d("network", "Request body: " + body);
-            req.write(body.getBytes("ASCII"));
+            req.write(body.getBytes(StandardCharsets.US_ASCII));
 
             try (InputStream resp = http.getInputStream()) {
                 Log.d("update_accounts", String.valueOf(http.getResponseCode()));
diff --git a/app/src/main/java/net/ktnx/mobileledger/utils/NetworkUtil.java b/app/src/main/java/net/ktnx/mobileledger/utils/NetworkUtil.java
index e6cc9acb..67adef06 100644
--- a/app/src/main/java/net/ktnx/mobileledger/utils/NetworkUtil.java
+++ b/app/src/main/java/net/ktnx/mobileledger/utils/NetworkUtil.java
@@ -26,6 +26,7 @@ import net.ktnx.mobileledger.model.MobileLedgerProfile;
 import java.io.IOException;
 import java.net.HttpURLConnection;
 import java.net.URL;
+import java.nio.charset.StandardCharsets;
 
 public final class NetworkUtil {
     private static final int thirtySeconds = 30000;
@@ -39,8 +40,8 @@ public final class NetworkUtil {
         if (use_auth) {
             final String auth_user = profile.getAuthUserName();
             final String auth_password = profile.getAuthPassword();
-            final byte[] bytes =
-                    (String.format("%s:%s", auth_user, auth_password)).getBytes("UTF-8");
+            final byte[] bytes = (String.format("%s:%s", auth_user, auth_password))
+                    .getBytes(StandardCharsets.UTF_8);
             final String value = Base64.encodeToString(bytes, Base64.DEFAULT);
             http.setRequestProperty("Authorization", "Basic " + value);
         }
-- 
2.39.2