From 56aa91f941cd17d7c37398bee00e447efe7c7308 Mon Sep 17 00:00:00 2001 From: Faye Duxovni Date: Thu, 9 Jun 2022 02:11:10 -0400 Subject: [PATCH] Fix representation of AmountPrecision for v1.23 In v1.23+, AmountPrecision is serialized and deserialized as though it's a Maybe Word8; it's expected to be either an integer or null, not a JSON object. --- .../json/v1_23/ParsedPosting.java | 2 +- .../json/v1_23/ParsedPrecision.java | 45 ------------------- .../mobileledger/json/v1_23/ParsedStyle.java | 6 +-- 3 files changed, 4 insertions(+), 49 deletions(-) delete mode 100644 app/src/main/java/net/ktnx/mobileledger/json/v1_23/ParsedPrecision.java diff --git a/app/src/main/java/net/ktnx/mobileledger/json/v1_23/ParsedPosting.java b/app/src/main/java/net/ktnx/mobileledger/json/v1_23/ParsedPosting.java index 8f0cdbcd..e60bd193 100644 --- a/app/src/main/java/net/ktnx/mobileledger/json/v1_23/ParsedPosting.java +++ b/app/src/main/java/net/ktnx/mobileledger/json/v1_23/ParsedPosting.java @@ -59,7 +59,7 @@ public class ParsedPosting extends net.ktnx.mobileledger.json.ParsedPosting { ParsedStyle style = new ParsedStyle(); style.setAscommodityside(getCommoditySide()); style.setAscommodityspaced(getCommoditySpaced()); - style.setAsprecision(new ParsedPrecision(2)); + style.setAsprecision(2); style.setAsdecimalpoint('.'); amt.setAstyle(style); if (acc.getCurrency() != null) diff --git a/app/src/main/java/net/ktnx/mobileledger/json/v1_23/ParsedPrecision.java b/app/src/main/java/net/ktnx/mobileledger/json/v1_23/ParsedPrecision.java deleted file mode 100644 index ffaac7db..00000000 --- a/app/src/main/java/net/ktnx/mobileledger/json/v1_23/ParsedPrecision.java +++ /dev/null @@ -1,45 +0,0 @@ -/* - * Copyright © 2020 Damyan Ivanov. - * This file is part of MoLe. - * MoLe is free software: you can distribute it and/or modify it - * under the term of the GNU General Public License as published by - * the Free Software Foundation, either version 3 of the License, or - * (at your opinion), any later version. - * - * MoLe is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License terms for details. - * - * You should have received a copy of the GNU General Public License - * along with MoLe. If not, see . - */ - -package net.ktnx.mobileledger.json.v1_23; - -import com.fasterxml.jackson.annotation.JsonIgnoreProperties; - -@JsonIgnoreProperties(ignoreUnknown = true) -class ParsedPrecision { - private int contents; - private String tag; - ParsedPrecision() { - tag = "NaturalPrecision"; - } - ParsedPrecision(int contents) { - this.contents = contents; - tag = "Precision"; - } - public int getContents() { - return contents; - } - public void setContents(int contents) { - this.contents = contents; - } - public String getTag() { - return tag; - } - public void setTag(String tag) { - this.tag = tag; - } -} diff --git a/app/src/main/java/net/ktnx/mobileledger/json/v1_23/ParsedStyle.java b/app/src/main/java/net/ktnx/mobileledger/json/v1_23/ParsedStyle.java index c9bf8bef..d3a0a133 100644 --- a/app/src/main/java/net/ktnx/mobileledger/json/v1_23/ParsedStyle.java +++ b/app/src/main/java/net/ktnx/mobileledger/json/v1_23/ParsedStyle.java @@ -21,13 +21,13 @@ import com.fasterxml.jackson.annotation.JsonIgnoreProperties; @JsonIgnoreProperties(ignoreUnknown = true) public class ParsedStyle extends net.ktnx.mobileledger.json.ParsedStyle { - private ParsedPrecision asprecision; + private int asprecision; public ParsedStyle() { } - public ParsedPrecision getAsprecision() { + public int getAsprecision() { return asprecision; } - public void setAsprecision(ParsedPrecision asprecision) { + public void setAsprecision(int asprecision) { this.asprecision = asprecision; } } -- 2.39.2