From 605837f87d9731e3529fa9be447bbcf7625cb2eb Mon Sep 17 00:00:00 2001
From: Damyan Ivanov <dam+mobileledger@ktnx.net>
Date: Thu, 17 Sep 2020 08:17:17 +0000
Subject: [PATCH] better shadow under main header in dark mode

with greater height and darker at the top edge. still black

tried with white and it looks very unnatural and like a mistake
---
 .../ui/activity/MainActivity.java             |  3 ++-
 .../main/res/drawable-anydpi/drop_shadow.xml  |  4 ++--
 app/src/main/res/layout/main_app_layout.xml   | 22 ++++++++++++-------
 app/src/main/res/values-night/styles.xml      |  3 +++
 app/src/main/res/values/attr.xml              |  4 +++-
 app/src/main/res/values/styles.xml            |  3 +++
 6 files changed, 27 insertions(+), 12 deletions(-)

diff --git a/app/src/main/java/net/ktnx/mobileledger/ui/activity/MainActivity.java b/app/src/main/java/net/ktnx/mobileledger/ui/activity/MainActivity.java
index bce01de7..1674c029 100644
--- a/app/src/main/java/net/ktnx/mobileledger/ui/activity/MainActivity.java
+++ b/app/src/main/java/net/ktnx/mobileledger/ui/activity/MainActivity.java
@@ -29,6 +29,7 @@ import android.os.Build;
 import android.os.Bundle;
 import android.util.Log;
 import android.view.View;
+import android.view.ViewGroup;
 import android.view.animation.AnimationUtils;
 import android.widget.LinearLayout;
 import android.widget.ProgressBar;
@@ -460,7 +461,7 @@ public class MainActivity extends ProfileThemedActivity {
         updateLastUpdateTextFromDB();
     }
     private void updateLastUpdateDisplay(Date newValue) {
-        LinearLayout l = findViewById(R.id.transactions_last_update_layout);
+        ViewGroup l = findViewById(R.id.transactions_last_update_layout);
         TextView v = findViewById(R.id.transactions_last_update);
         if (newValue == null) {
             l.setVisibility(View.INVISIBLE);
diff --git a/app/src/main/res/drawable-anydpi/drop_shadow.xml b/app/src/main/res/drawable-anydpi/drop_shadow.xml
index 1a37f95c..4eae334e 100644
--- a/app/src/main/res/drawable-anydpi/drop_shadow.xml
+++ b/app/src/main/res/drawable-anydpi/drop_shadow.xml
@@ -17,8 +17,8 @@
 
 <shape xmlns:android="http://schemas.android.com/apk/res/android">
     <gradient
-        android:startColor="#80000000"
-        android:endColor="#00000000"
+        android:startColor="?attr/shadowStartColor"
+        android:endColor="?attr/shadowEndColor"
         android:angle="270"
         />
 </shape>
\ No newline at end of file
diff --git a/app/src/main/res/layout/main_app_layout.xml b/app/src/main/res/layout/main_app_layout.xml
index 784e0b6a..d9f4b426 100644
--- a/app/src/main/res/layout/main_app_layout.xml
+++ b/app/src/main/res/layout/main_app_layout.xml
@@ -70,32 +70,38 @@
                 app:layout_constraintStart_toStartOf="parent"
                 app:layout_constraintTop_toBottomOf="@id/toolbar">
 
-                <LinearLayout
+                <androidx.constraintlayout.widget.ConstraintLayout
                     android:id="@+id/transactions_last_update_layout"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:elevation="24dp"
-                    android:orientation="horizontal">
+                    android:orientation="horizontal"
+                    >
 
                     <TextView
                         android:id="@+id/transaction_last_update_label"
-                        android:textAppearance="@android:style/TextAppearance.Material.Small"
-                        android:layout_width="wrap_content"
+                        android:layout_width="0dp"
                         android:layout_height="wrap_content"
                         android:paddingStart="8dp"
                         android:paddingEnd="8dp"
                         android:text="@string/transactions_last_update_label"
+                        android:textAppearance="@android:style/TextAppearance.Material.Small"
+                        app:layout_constraintEnd_toStartOf="@id/transactions_last_update"
+                        app:layout_constraintTop_toTopOf="parent"
                         />
 
                     <TextView
                         android:id="@+id/transactions_last_update"
-                        android:textAppearance="@android:style/TextAppearance.Material.Small"
                         android:layout_width="0dp"
                         android:layout_height="wrap_content"
                         android:layout_weight="1"
                         android:text="\?"
-                        tools:ignore="HardcodedText" />
-                </LinearLayout>
+                        android:textAppearance="@android:style/TextAppearance.Material.Small"
+                        tools:ignore="HardcodedText"
+                        app:layout_constraintEnd_toEndOf="parent"
+                        app:layout_constraintTop_toTopOf="parent"
+                        />
+                </androidx.constraintlayout.widget.ConstraintLayout>
 
                 <LinearLayout
                     android:id="@+id/transaction_progress_layout"
@@ -145,7 +151,7 @@
 
             <View
                 android:layout_width="0dp"
-                android:layout_height="4dp"
+                android:layout_height="?attr/main_header_shadow_height"
                 android:background="@drawable/drop_shadow"
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintStart_toStartOf="parent"
diff --git a/app/src/main/res/values-night/styles.xml b/app/src/main/res/values-night/styles.xml
index 1b39c9e2..1b832d3e 100644
--- a/app/src/main/res/values-night/styles.xml
+++ b/app/src/main/res/values-night/styles.xml
@@ -35,6 +35,9 @@
         </item>
         <item name="colorError">#FFE1E2</item>
         <item name="colorOnError">#CD1609</item>
+        <item name="main_header_shadow_height">12dp</item>
+        <item name="shadowStartColor">#C0000000</item>
+        <item name="shadowEndColor">#00000000</item>
     </style>
 
     <!-- theme list start -->
diff --git a/app/src/main/res/values/attr.xml b/app/src/main/res/values/attr.xml
index 27732050..b3499597 100644
--- a/app/src/main/res/values/attr.xml
+++ b/app/src/main/res/values/attr.xml
@@ -23,5 +23,7 @@
     <attr name="textColor" format="reference|color"/>
     <attr name="commentColor" format="reference|color" />
     <attr name="colorPrimaryTransparent" format="reference|color" />
-
+    <attr name="main_header_shadow_height" format="reference|dimension" />
+    <attr name="shadowStartColor" format="reference|color" />
+    <attr name="shadowEndColor" format="reference|color" />
 </resources>
\ No newline at end of file
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index c51c46a2..d56120ef 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -39,6 +39,9 @@
         <item name="table_row_dark_bg">#efe7fd</item>
         <item name="table_row_light_bg">#f9f6fe</item>
         <item name="background">@null</item>
+        <item name="main_header_shadow_height">4dp</item>
+        <item name="shadowStartColor">#80000000</item>
+        <item name="shadowEndColor">#00000000</item>
     </style>
 
     <!-- theme list start -->
-- 
2.39.2