From b36e2e3152f57528aacf94f31985952cf80406a4 Mon Sep 17 00:00:00 2001
From: Damyan Ivanov <dam+mobileledger@ktnx.net>
Date: Sun, 7 Mar 2021 11:16:34 +0200
Subject: [PATCH] handle menu items click hooks by code in new transaction
 activity

---
 .../ui/new_transaction/NewTransactionActivity.java    | 11 +++++++++--
 app/src/main/res/menu/new_transaction.xml             |  2 --
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/app/src/main/java/net/ktnx/mobileledger/ui/new_transaction/NewTransactionActivity.java b/app/src/main/java/net/ktnx/mobileledger/ui/new_transaction/NewTransactionActivity.java
index 5bba06e1..ce97d985 100644
--- a/app/src/main/java/net/ktnx/mobileledger/ui/new_transaction/NewTransactionActivity.java
+++ b/app/src/main/java/net/ktnx/mobileledger/ui/new_transaction/NewTransactionActivity.java
@@ -155,9 +155,10 @@ public class NewTransactionActivity extends ProfileThemedActivity
             navController.navigate(R.id.newTransactionFragment, b);
         }
     }
-    public void simulateCrash(MenuItem item) {
+    public boolean onSimulateCrashMenuItemClicked(MenuItem item) {
         debug("crash", "Will crash intentionally");
         new AsyncCrasher().execute();
+        return true;
     }
     public boolean onCreateOptionsMenu(Menu menu) {
         super.onCreateOptionsMenu(menu);
@@ -170,6 +171,11 @@ public class NewTransactionActivity extends ProfileThemedActivity
 
         MenuCompat.setGroupDividerEnabled(menu, true);
 
+        menu.findItem(R.id.action_simulate_save)
+            .setOnMenuItemClickListener(this::onToggleSimulateSaveMenuItemClicked);
+        menu.findItem(R.id.action_simulate_crash)
+            .setOnMenuItemClickListener(this::onSimulateCrashMenuItemClicked);
+
         model.getSimulateSave()
              .observe(this, state -> {
                  menu.findItem(R.id.action_simulate_save)
@@ -195,8 +201,9 @@ public class NewTransactionActivity extends ProfileThemedActivity
         else
             navController.navigate(R.id.action_newTransactionSavingFragment_Success, b);
     }
-    public void toggleSimulateSave(MenuItem item) {
+    public boolean onToggleSimulateSaveMenuItemClicked(MenuItem item) {
         model.toggleSimulateSave();
+        return true;
     }
 
     @Override
diff --git a/app/src/main/res/menu/new_transaction.xml b/app/src/main/res/menu/new_transaction.xml
index 15fe57b0..f4862d8c 100644
--- a/app/src/main/res/menu/new_transaction.xml
+++ b/app/src/main/res/menu/new_transaction.xml
@@ -21,7 +21,6 @@
     <group android:id="@+id/new_transaction_debug_menu_items">
         <item
             android:id="@+id/action_simulate_crash"
-            android:onClick="simulateCrash"
             android:title="@string/crash_app_label"
             android:titleCondensed="@string/crash_app_condensed_label"
             app:showAsAction="never"
@@ -30,7 +29,6 @@
             android:id="@+id/action_simulate_save"
             android:checkable="true"
             android:checked="false"
-            android:onClick="toggleSimulateSave"
             android:title="@string/simulate_save_label"
             android:titleCondensed="@string/simulate_save_condensed_label"
             app:showAsAction="never"
-- 
2.39.2