From d6a89986ed3ce01632c2b3313f55c60a8f0a5cc0 Mon Sep 17 00:00:00 2001
From: Damyan Ivanov <dam+mobileledger@ktnx.net>
Date: Sat, 12 Jan 2019 13:07:01 +0000
Subject: [PATCH] somewhat more visible marker between months

---
 .../TransactionListAdapter.java               | 11 ++++++--
 .../TransactionRowHolder.java                 |  2 ++
 .../main/res/drawable/dashed_border_8dp.xml   | 28 +++++++++++++++++++
 .../main/res/layout/transaction_list_row.xml  |  2 +-
 4 files changed, 40 insertions(+), 3 deletions(-)
 create mode 100644 app/src/main/res/drawable/dashed_border_8dp.xml

diff --git a/app/src/main/java/net/ktnx/mobileledger/ui/transaction_list/TransactionListAdapter.java b/app/src/main/java/net/ktnx/mobileledger/ui/transaction_list/TransactionListAdapter.java
index febca019..0e79b7ae 100644
--- a/app/src/main/java/net/ktnx/mobileledger/ui/transaction_list/TransactionListAdapter.java
+++ b/app/src/main/java/net/ktnx/mobileledger/ui/transaction_list/TransactionListAdapter.java
@@ -82,8 +82,15 @@ public class TransactionListAdapter extends RecyclerView.Adapter<TransactionRowH
             holder.vTransaction.setVisibility(View.GONE);
             holder.vDelimiter.setVisibility(View.VISIBLE);
             holder.tvDelimiterDate.setText(DateFormat.getDateInstance().format(date));
-            holder.tvDelimiterMonth
-                    .setText(item.isMonthShown() ? Globals.monthNames[date.getMonth()] : "");
+            if (item.isMonthShown()) {
+                holder.tvDelimiterMonth.setText(Globals.monthNames[date.getMonth()]);
+                holder.tvDelimiterMonth.setVisibility(View.VISIBLE);
+                holder.vDelimiterLine.setBackgroundResource(R.drawable.dashed_border_8dp);
+            }
+            else {
+                holder.tvDelimiterMonth.setVisibility(View.GONE);
+                holder.vDelimiterLine.setBackgroundResource(R.drawable.dashed_border_1dp);
+            }
         }
     }
 
diff --git a/app/src/main/java/net/ktnx/mobileledger/ui/transaction_list/TransactionRowHolder.java b/app/src/main/java/net/ktnx/mobileledger/ui/transaction_list/TransactionRowHolder.java
index f23311a0..91111a6f 100644
--- a/app/src/main/java/net/ktnx/mobileledger/ui/transaction_list/TransactionRowHolder.java
+++ b/app/src/main/java/net/ktnx/mobileledger/ui/transaction_list/TransactionRowHolder.java
@@ -34,6 +34,7 @@ class TransactionRowHolder extends RecyclerView.ViewHolder {
     ConstraintLayout vDelimiter;
     CardView vTransaction;
     TextView tvDelimiterMonth, tvDelimiterDate;
+    View vDelimiterLine;
     public TransactionRowHolder(@NonNull View itemView) {
         super(itemView);
         this.row = itemView.findViewById(R.id.transaction_row);
@@ -43,5 +44,6 @@ class TransactionRowHolder extends RecyclerView.ViewHolder {
         this.vTransaction = itemView.findViewById(R.id.transaction_card_view);
         this.tvDelimiterDate = itemView.findViewById(R.id.transaction_delimiter_date);
         this.tvDelimiterMonth = itemView.findViewById(R.id.transaction_delimiter_month);
+        this.vDelimiterLine = itemView.findViewById(R.id.transaction_delimiter_line);
     }
 }
diff --git a/app/src/main/res/drawable/dashed_border_8dp.xml b/app/src/main/res/drawable/dashed_border_8dp.xml
new file mode 100644
index 00000000..c77f8d8e
--- /dev/null
+++ b/app/src/main/res/drawable/dashed_border_8dp.xml
@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="utf-8"?><!--
+  ~ Copyright © 2019 Damyan Ivanov.
+  ~ This file is part of Mobile-Ledger.
+  ~ Mobile-Ledger is free software: you can distribute it and/or modify it
+  ~ under the term of the GNU General Public License as published by
+  ~ the Free Software Foundation, either version 3 of the License, or
+  ~ (at your opinion), any later version.
+  ~
+  ~ Mobile-Ledger is distributed in the hope that it will be useful,
+  ~ but WITHOUT ANY WARRANTY; without even the implied warranty of
+  ~ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+  ~ GNU General Public License terms for details.
+  ~
+  ~ You should have received a copy of the GNU General Public License
+  ~ along with Mobile-Ledger. If not, see <https://www.gnu.org/licenses/>.
+  -->
+
+<shape xmlns:android="http://schemas.android.com/apk/res/android"
+    android:shape="line"
+    android:thickness="1dp"
+    android:tint="@color/header_border">
+    <stroke
+        android:width="8dp"
+        android:color="@color/colorPrimaryDark"
+        android:dashWidth="16dp"
+        android:dashGap="8dp" />
+
+</shape>
\ No newline at end of file
diff --git a/app/src/main/res/layout/transaction_list_row.xml b/app/src/main/res/layout/transaction_list_row.xml
index 775dc79f..256ebb24 100644
--- a/app/src/main/res/layout/transaction_list_row.xml
+++ b/app/src/main/res/layout/transaction_list_row.xml
@@ -171,7 +171,7 @@
             tools:ignore="HardcodedText" />
 
         <View
-            android:id="@+id/view"
+            android:id="@+id/transaction_delimiter_line"
             android:layout_width="0dp"
             android:layout_height="0dp"
             android:layout_marginStart="8dp"
-- 
2.39.2