new transaction: locale-aware number formatting (broken in RecyclerView migration)

[mobile-ledger-staging.git] / app / src / main / java / net / ktnx / mobileledger / ui / activity / NewTransactionItemHolder.java

diff --git a/app/src/main/java/net/ktnx/mobileledger/ui/activity/NewTransactionItemHolder.java b/app/src/main/java/net/ktnx/mobileledger/ui/activity/NewTransactionItemHolder.java
index 387a25486d5089cbd209076fb3eb25aa38e574f4..123b91e93ae534e24103b2a3e3a572f729006812 100644 (file)
--- a/app/src/main/java/net/ktnx/mobileledger/ui/activity/NewTransactionItemHolder.java
+++ b/app/src/main/java/net/ktnx/mobileledger/ui/activity/NewTransactionItemHolder.java
@@ -17,6 +17,7 @@
 
 package net.ktnx.mobileledger.ui.activity;
 
+import android.annotation.SuppressLint;
 import android.text.Editable;
 import android.text.TextWatcher;
 import android.view.View;
@@ -81,12 +82,14 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
         tvAmount.setNextFocusForwardId(View.NO_ID); // magic!
 
         tvDate.setOnFocusChangeListener((v, hasFocus) -> {
-            if (hasFocus) pickTransactionDate();
+            if (hasFocus)
+                pickTransactionDate();
         });
         tvDate.setOnClickListener(v -> pickTransactionDate());
 
         mProfile = Data.profile.getValue();
-        if (mProfile == null) throw new AssertionError();
+        if (mProfile == null)
+            throw new AssertionError();
 
         MLDB.hookAutocompletionAdapter(tvDescription.getContext(), tvDescription,
                 MLDB.DESCRIPTION_HISTORY_TABLE, "description", false, adapter, mProfile);
@@ -105,7 +108,8 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
             @Override
             public void afterTextChanged(Editable s) {
 //                debug("input", "text changed");
-                if (inUpdate) return;
+                if (inUpdate)
+                    return;
 
                 Logger.debug("textWatcher", "calling syncData()");
                 syncData();
@@ -120,7 +124,8 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
         tvAmount.addTextChangedListener(tw);
 
         dateObserver = date -> {
-            if (syncingData) return;
+            if (syncingData)
+                return;
             syncingData = true;
             try {
                 tvDate.setText(item.getFormattedDate());
@@ -130,7 +135,8 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
             }
         };
         descriptionObserver = description -> {
-            if (syncingData) return;
+            if (syncingData)
+                return;
             syncingData = true;
             try {
                 tvDescription.setText(description);
@@ -140,9 +146,13 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
             }
         };
         hintObserver = hint -> {
-            if (syncingData) return;
+            if (syncingData)
+                return;
             syncingData = true;
             try {
+                if (hint == null)
+                    hint = tvAmount.getResources()
+                                   .getString(R.string.zero_amount);
                 tvAmount.setHint(hint);
             }
             finally {
@@ -159,8 +169,9 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
                         //if (!tvDate.hasFocus()) tvDate.requestFocus();
                         boolean focused = tvDescription.requestFocus();
                         tvDescription.dismissDropDown();
-                        if (focused) Misc.showSoftKeyboard(
-                                (NewTransactionActivity) tvDescription.getContext());
+                        if (focused)
+                            Misc.showSoftKeyboard(
+                                    (NewTransactionActivity) tvDescription.getContext());
                         break;
                     case transactionRow:
                         focused = tvAccount.requestFocus();
@@ -192,8 +203,10 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
                                                                                  item.getAccount()
                                                                                      .getAmount())
                                                                          : "unset") : "")));
-            if (adapterPosition == count) tvAmount.setImeOptions(EditorInfo.IME_ACTION_DONE);
-            else tvAmount.setImeOptions(EditorInfo.IME_ACTION_NEXT);
+            if (adapterPosition == count)
+                tvAmount.setImeOptions(EditorInfo.IME_ACTION_DONE);
+            else
+                tvAmount.setImeOptions(EditorInfo.IME_ACTION_NEXT);
         };
     }
     private void setEditable(Boolean editable) {
@@ -203,11 +216,13 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
         tvAmount.setEnabled(editable);
     }
     private void beginUpdates() {
-        if (inUpdate) throw new RuntimeException("Already in update mode");
+        if (inUpdate)
+            throw new RuntimeException("Already in update mode");
         inUpdate = true;
     }
     private void endUpdates() {
-        if (!inUpdate) throw new RuntimeException("Not in update mode");
+        if (!inUpdate)
+            throw new RuntimeException("Not in update mode");
         inUpdate = false;
     }
     /**
@@ -216,7 +231,8 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
      * Stores the data from the UI elements into the model item
      */
     private void syncData() {
-        if (item == null) return;
+        if (item == null)
+            return;
 
         if (syncingData) {
             Logger.debug("new-trans", "skipping syncData() loop");
@@ -253,8 +269,9 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
                                 .resetAmount();
                         }
                     }
-                    else item.getAccount()
-                             .resetAmount();
+                    else
+                        item.getAccount()
+                            .resetAmount();
 
                     break;
                 case bottomFiller:
@@ -276,6 +293,7 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
      *
      * @param item updates the UI elements with the data from the model item
      */
+    @SuppressLint("DefaultLocale")
     public void setData(NewTransactionModel.Item item) {
         beginUpdates();
         try {
@@ -305,8 +323,7 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
                     LedgerTransactionAccount acc = item.getAccount();
                     tvAccount.setText(acc.getAccountName());
                     tvAmount.setText(
-                            acc.isAmountSet() ? String.format(Locale.US, "%1.2f", acc.getAmount())
-                                              : "");
+                            acc.isAmountSet() ? String.format("%1.2f", acc.getAmount()) : "");
                     lHead.setVisibility(View.GONE);
                     lAccount.setVisibility(View.VISIBLE);
                     lPadding.setVisibility(View.GONE);
@@ -344,7 +361,8 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
         c.set(year, month, day);
         item.setDate(c.getTime());
         boolean focused = tvDescription.requestFocus();
-        if (focused) Misc.showSoftKeyboard((NewTransactionActivity) tvAccount.getContext());
+        if (focused)
+            Misc.showSoftKeyboard((NewTransactionActivity) tvAccount.getContext());
 
     }
     @Override