wrap Log.d calls, skipping them on non-debug builds

[mobile-ledger.git] / app / src / main / java / net / ktnx / mobileledger / async / CommitAccountsTask.java

diff --git a/app/src/main/java/net/ktnx/mobileledger/async/CommitAccountsTask.java b/app/src/main/java/net/ktnx/mobileledger/async/CommitAccountsTask.java
index 7368d712d88ce19eabddc12353d50753b9133372..2c3d90f83947f9c7576624d718a84f9c218b4847 100644 (file)
--- a/app/src/main/java/net/ktnx/mobileledger/async/CommitAccountsTask.java
+++ b/app/src/main/java/net/ktnx/mobileledger/async/CommitAccountsTask.java
@@ -19,42 +19,48 @@ package net.ktnx.mobileledger.async;
 
 import android.database.sqlite.SQLiteDatabase;
 import android.os.AsyncTask;
-import android.util.Log;
 
 import net.ktnx.mobileledger.model.Data;
 import net.ktnx.mobileledger.model.LedgerAccount;
+import net.ktnx.mobileledger.utils.LockHolder;
 import net.ktnx.mobileledger.utils.MLDB;
 
 import java.util.ArrayList;
 
+import static net.ktnx.mobileledger.utils.Logger.debug;
+
 public class CommitAccountsTask
         extends AsyncTask<CommitAccountsTaskParams, Void, ArrayList<LedgerAccount>> {
     protected ArrayList<LedgerAccount> doInBackground(CommitAccountsTaskParams... params) {
-        Data.backgroundTaskCount.incrementAndGet();
+        Data.backgroundTaskStarted();
         ArrayList<LedgerAccount> newList = new ArrayList<>();
         String profile = Data.profile.get().getUuid();
         try {
 
-            SQLiteDatabase db = MLDB.getWritableDatabase();
+            SQLiteDatabase db = MLDB.getDatabase();
             db.beginTransaction();
             try {
-                for (LedgerAccount acc : params[0].accountList) {
-                    Log.d("CAT", String.format("Setting %s to %s", acc.getName(),
-                            acc.isHiddenByStarToBe() ? "hidden" : "starred"));
-                    db.execSQL("UPDATE accounts SET hidden=? WHERE profile=? AND name=?",
-                            new Object[]{acc.isHiddenByStarToBe() ? 1 : 0, profile, acc.getName()});
-
-                    acc.setHiddenByStar(acc.isHiddenByStarToBe());
-                    if (!params[0].showOnlyStarred || !acc.isHiddenByStar()) newList.add(acc);
+                try (LockHolder lh = params[0].accountList.lockForWriting()) {
+                    for (int i = 0; i < params[0].accountList.size(); i++ ){
+                        LedgerAccount acc = params[0].accountList.get(i);
+                        debug("CAT", String.format("Setting %s to %s", acc.getName(),
+                                acc.isHiddenByStarToBe() ? "hidden" : "starred"));
+                        db.execSQL("UPDATE accounts SET hidden=? WHERE profile=? AND name=?",
+                                new Object[]{acc.isHiddenByStarToBe() ? 1 : 0, profile, acc.getName()
+                                });
+
+                        acc.setHiddenByStar(acc.isHiddenByStarToBe());
+                        if (!params[0].showOnlyStarred || !acc.isHiddenByStar()) newList.add(acc);
+                    }
+                    db.setTransactionSuccessful();
                 }
-                db.setTransactionSuccessful();
             }
             finally {
                 db.endTransaction();
             }
         }
         finally {
-            Data.backgroundTaskCount.decrementAndGet();
+            Data.backgroundTaskFinished();
         }
 
         return newList;