fix finding the earliest transaction by date

[mobile-ledger.git] / app / src / main / java / net / ktnx / mobileledger / async / TransactionDateFinder.java

diff --git a/app/src/main/java/net/ktnx/mobileledger/async/TransactionDateFinder.java b/app/src/main/java/net/ktnx/mobileledger/async/TransactionDateFinder.java
index c15e59906e9932d4ca9453d0aecf5aefd3f1b97b..2bce07e1ca08fc4218aa7aba911491c9fc2c5c87 100644 (file)
--- a/app/src/main/java/net/ktnx/mobileledger/async/TransactionDateFinder.java
+++ b/app/src/main/java/net/ktnx/mobileledger/async/TransactionDateFinder.java
@@ -1,5 +1,5 @@
 /*
- * Copyright © 2020 Damyan Ivanov.
+ * Copyright © 2021 Damyan Ivanov.
  * This file is part of MoLe.
  * MoLe is free software: you can distribute it and/or modify it
  * under the term of the GNU General Public License as published by
@@ -19,59 +19,80 @@ package net.ktnx.mobileledger.async;
 
 import android.os.AsyncTask;
 
-import net.ktnx.mobileledger.model.Data;
 import net.ktnx.mobileledger.model.TransactionListItem;
-import net.ktnx.mobileledger.utils.LockHolder;
+import net.ktnx.mobileledger.ui.MainModel;
 import net.ktnx.mobileledger.utils.Logger;
 import net.ktnx.mobileledger.utils.SimpleDate;
 
+import org.jetbrains.annotations.NotNull;
+
 import java.util.Collections;
 import java.util.Comparator;
 import java.util.List;
 import java.util.Locale;
+import java.util.Objects;
 
-public class TransactionDateFinder extends AsyncTask<SimpleDate, Void, Integer> {
+public class TransactionDateFinder extends AsyncTask<TransactionDateFinder.Params, Void, Integer> {
+    private MainModel model;
     @Override
     protected void onPostExecute(Integer pos) {
-        Data.foundTransactionItemIndex.setValue(pos);
+        model.foundTransactionItemIndex.setValue(pos);
     }
     @Override
-    protected Integer doInBackground(SimpleDate... simpleDates) {
-        SimpleDate date = simpleDates[0];
+    protected Integer doInBackground(Params... param) {
+        this.model = param[0].model;
+        SimpleDate date = param[0].date;
         Logger.debug("go-to-date",
                 String.format(Locale.US, "Looking for date %04d-%02d-%02d", date.year, date.month,
                         date.day));
-        Logger.debug("go-to-date", String.format(Locale.US, "List contains %d transactions",
-                Data.transactions.size()));
+        List<TransactionListItem> transactions = Objects.requireNonNull(
+                param[0].model.getDisplayedTransactions()
+                              .getValue());
+        final int transactionCount = transactions.size();
+        Logger.debug("go-to-date",
+                String.format(Locale.US, "List contains %d transactions", transactionCount));
 
-        try (LockHolder locker = Data.transactions.lockForWriting()) {
-            List<TransactionListItem> transactions = Data.transactions.getList();
-            TransactionListItem target = new TransactionListItem(date, true);
-            int found = Collections.binarySearch(transactions, target,
-                    new TransactionListItemComparator());
-            if (found >= 0)
-                return found;
-            else
-                return 1 - found;
+        TransactionListItem target = new TransactionListItem(date, true);
+        int found =
+                Collections.binarySearch(transactions, target, new TransactionListItemComparator());
+        if (found >= 0)
+            return found;
+        else
+            return -1 - found;
+    }
+
+    public static class Params {
+        public final MainModel model;
+        public final SimpleDate date;
+        public Params(@NotNull MainModel model, @NotNull SimpleDate date) {
+            this.model = model;
+            this.date = date;
         }
     }
+
     static class TransactionListItemComparator implements Comparator<TransactionListItem> {
         @Override
-        public int compare(TransactionListItem a, TransactionListItem b) {
+        public int compare(@NotNull TransactionListItem a, @NotNull TransactionListItem b) {
+            final TransactionListItem.Type aType = a.getType();
+            if (aType == TransactionListItem.Type.HEADER)
+                return +1;
+            final TransactionListItem.Type bType = b.getType();
+            if (bType == TransactionListItem.Type.HEADER)
+                return -1;
             final SimpleDate aDate = a.getDate();
             final SimpleDate bDate = b.getDate();
             int res = aDate.compareTo(bDate);
             if (res != 0)
                 return -res;    // transactions are reverse sorted by date
 
-            if (a.getType() == TransactionListItem.Type.DELIMITER) {
-                if (b.getType() == TransactionListItem.Type.DELIMITER)
+            if (aType == TransactionListItem.Type.DELIMITER) {
+                if (bType == TransactionListItem.Type.DELIMITER)
                     return 0;
                 else
                     return -1;
             }
             else {
-                if (b.getType() == TransactionListItem.Type.DELIMITER)
+                if (bType == TransactionListItem.Type.DELIMITER)
                     return +1;
                 else
                     return 0;