asking UpdateTransactionsTask to load a null profile is fine

[mobile-ledger.git] / app / src / main / java / net / ktnx / mobileledger / async / UpdateTransactionsTask.java

diff --git a/app/src/main/java/net/ktnx/mobileledger/async/UpdateTransactionsTask.java b/app/src/main/java/net/ktnx/mobileledger/async/UpdateTransactionsTask.java
index 43de74025ad83ca7dc8dd511080dcc60d2d3c55c..38db6b17f8c7b30648a92d980f23626f4fbe222e 100644 (file)
--- a/app/src/main/java/net/ktnx/mobileledger/async/UpdateTransactionsTask.java
+++ b/app/src/main/java/net/ktnx/mobileledger/async/UpdateTransactionsTask.java
@@ -1,5 +1,5 @@
 /*
- * Copyright © 2020 Damyan Ivanov.
+ * Copyright © 2021 Damyan Ivanov.
  * This file is part of MoLe.
  * MoLe is free software: you can distribute it and/or modify it
  * under the term of the GNU General Public License as published by
@@ -17,59 +17,56 @@
 
 package net.ktnx.mobileledger.async;
 
-import android.database.Cursor;
-import android.database.sqlite.SQLiteDatabase;
 import android.os.AsyncTask;
 
-import net.ktnx.mobileledger.App;
+import net.ktnx.mobileledger.db.DB;
+import net.ktnx.mobileledger.db.Profile;
+import net.ktnx.mobileledger.db.TransactionWithAccounts;
 import net.ktnx.mobileledger.model.Data;
 import net.ktnx.mobileledger.model.LedgerTransaction;
-import net.ktnx.mobileledger.model.MobileLedgerProfile;
 import net.ktnx.mobileledger.ui.MainModel;
-import net.ktnx.mobileledger.utils.SimpleDate;
+import net.ktnx.mobileledger.utils.Logger;
 
+import java.util.ArrayList;
+import java.util.List;
+
+import static net.ktnx.mobileledger.db.Profile.NO_PROFILE_ID;
 import static net.ktnx.mobileledger.utils.Logger.debug;
 
 public class UpdateTransactionsTask extends AsyncTask<MainModel, Void, String> {
-    protected String doInBackground(MainModel[] model) {
-        final MobileLedgerProfile profile = Data.getProfile();
+    protected String doInBackground(MainModel[] parentModel) {
+        final Profile profile = Data.getProfile();
 
-        String profile_uuid = profile.getUuid();
+        long profileId = (profile == null) ? NO_PROFILE_ID : profile.getId();
         Data.backgroundTaskStarted();
         try {
-            String sql;
-            String[] params;
+            Logger.debug("UTT", "Starting DB transaction list retrieval");
 
-            final String accFilter = model[0].getAccountFilter()
-                                             .getValue();
-            if (accFilter == null) {
-                sql = "SELECT id, year, month, day FROM transactions WHERE profile=? ORDER BY " +
-                      "year desc, month desc, day desc, id desc";
-                params = new String[]{profile_uuid};
+            final MainModel model = parentModel[0];
+            final String accFilter = model.getAccountFilter()
+                                          .getValue();
+            final List<TransactionWithAccounts> transactions;
 
+            if (profileId == NO_PROFILE_ID)
+                transactions = new ArrayList<>();
+            else if (accFilter == null) {
+                transactions = DB.get()
+                                 .getTransactionDAO()
+                                 .getAllWithAccountsSync(profileId);
             }
             else {
-                sql = "SELECT distinct tr.id, tr.year, tr.month, tr.day from transactions tr " +
-                      "JOIN " + "transaction_accounts ta " +
-                      "ON ta.transaction_id=tr.id AND ta.profile=tr.profile WHERE tr.profile=? " +
-                      "and ta.account_name LIKE ?||'%' AND ta" +
-                      ".amount <> 0 ORDER BY tr.year desc, tr.month desc, tr.day desc, tr.id " +
-                      "desc";
-                params = new String[]{profile_uuid, accFilter};
+                transactions = DB.get()
+                                 .getTransactionDAO()
+                                 .getAllWithAccountsFilteredSync(profileId, accFilter);
             }
 
-            debug("UTT", sql);
-            TransactionAccumulator accumulator = new TransactionAccumulator(model[0]);
+            TransactionAccumulator accumulator = new TransactionAccumulator(model);
 
-            SQLiteDatabase db = App.getDatabase();
-            try (Cursor cursor = db.rawQuery(sql, params)) {
-                while (cursor.moveToNext()) {
-                    if (isCancelled())
-                        return null;
+            for (TransactionWithAccounts tr : transactions) {
+                if (isCancelled())
+                    return null;
 
-                    accumulator.put(new LedgerTransaction(cursor.getInt(0)),
-                            new SimpleDate(cursor.getInt(1), cursor.getInt(2), cursor.getInt(3)));
-                }
+                accumulator.put(new LedgerTransaction(tr));
             }
 
             accumulator.done();