]> git.ktnx.net Git - mobile-ledger.git/blobdiff - app/src/main/java/net/ktnx/mobileledger/model/MobileLedgerProfile.java
reuse the SQL parameter list that is the same for the 5 calls
[mobile-ledger.git] / app / src / main / java / net / ktnx / mobileledger / model / MobileLedgerProfile.java
index e466d3d906312d440808e68957e5b9bcfcbb0b47..6ebba5762da199c65223f3c4702b73c970c319cf 100644 (file)
@@ -21,7 +21,9 @@ import android.database.Cursor;
 import android.database.sqlite.SQLiteDatabase;
 import android.util.Log;
 
+import net.ktnx.mobileledger.async.DbOpQueue;
 import net.ktnx.mobileledger.utils.Globals;
+import net.ktnx.mobileledger.utils.LockHolder;
 import net.ktnx.mobileledger.utils.MLDB;
 
 import java.util.ArrayList;
@@ -42,36 +44,11 @@ public final class MobileLedgerProfile {
     private String authPassword;
     private int themeId;
     private int orderNo = -1;
-    public MobileLedgerProfile(String uuid, String name, boolean permitPosting, String url,
-                               boolean authEnabled, String authUserName, String authPassword) {
-        this(uuid, name, permitPosting, url, authEnabled, authUserName, authPassword, -1);
-
+    public MobileLedgerProfile() {
+        this.uuid = String.valueOf(UUID.randomUUID());
     }
-    public MobileLedgerProfile(String uuid, String name, boolean permitPosting, String url,
-                               boolean authEnabled, String authUserName, String authPassword,
-                               int themeId) {
+    public MobileLedgerProfile(String uuid) {
         this.uuid = uuid;
-        this.name = name;
-        this.permitPosting = permitPosting;
-        this.url = url;
-        this.authEnabled = authEnabled;
-        this.authUserName = authUserName;
-        this.authPassword = authPassword;
-        this.themeId = themeId;
-        this.orderNo = -1;
-    }
-    public MobileLedgerProfile(CharSequence name, boolean permitPosting, CharSequence url,
-                               boolean authEnabled, CharSequence authUserName,
-                               CharSequence authPassword, int themeId) {
-        this.uuid = String.valueOf(UUID.randomUUID());
-        this.name = String.valueOf(name);
-        this.permitPosting = permitPosting;
-        this.url = String.valueOf(url);
-        this.authEnabled = authEnabled;
-        this.authUserName = String.valueOf(authUserName);
-        this.authPassword = String.valueOf(authPassword);
-        this.themeId = themeId;
-        this.orderNo = -1;
     }
     // loads all profiles into Data.profiles
     // returns the profile with the given UUID
@@ -84,10 +61,14 @@ public final class MobileLedgerProfile {
                                          "profiles order by order_no", null))
         {
             while (cursor.moveToNext()) {
-                MobileLedgerProfile item =
-                        new MobileLedgerProfile(cursor.getString(0), cursor.getString(1),
-                                cursor.getInt(6) == 1, cursor.getString(2), cursor.getInt(3) == 1,
-                                cursor.getString(4), cursor.getString(5), cursor.getInt(7));
+                MobileLedgerProfile item = new MobileLedgerProfile(cursor.getString(0));
+                item.setName(cursor.getString(1));
+                item.setUrl(cursor.getString(2));
+                item.setAuthEnabled(cursor.getInt(3) == 1);
+                item.setAuthUserName(cursor.getString(4));
+                item.setAuthPassword(cursor.getString(5));
+                item.setPostingPermitted(cursor.getInt(6) == 1);
+                item.setThemeId(cursor.getInt(7));
                 item.orderNo = cursor.getInt(8);
                 list.add(item);
                 if (item.getUuid().equals(currentProfileUUID)) result = item;
@@ -101,11 +82,14 @@ public final class MobileLedgerProfile {
         db.beginTransaction();
         try {
             int orderNo = 0;
-            for (MobileLedgerProfile p : Data.profiles.getList()) {
-                db.execSQL("update profiles set order_no=? where uuid=?",
-                        new Object[]{orderNo, p.getUuid()});
-                p.orderNo = orderNo;
-                orderNo++;
+            try (LockHolder lh = Data.profiles.lockForReading()) {
+                for (int i = 0; i < Data.profiles.size(); i++) {
+                    MobileLedgerProfile p = Data.profiles.get(i);
+                    db.execSQL("update profiles set order_no=? where uuid=?",
+                            new Object[]{orderNo, p.getUuid()});
+                    p.orderNo = orderNo;
+                    orderNo++;
+                }
             }
             db.setTransactionSuccessful();
         }
@@ -125,21 +109,21 @@ public final class MobileLedgerProfile {
     public String getName() {
         return name;
     }
-    public void setName(String name) {
-        this.name = name;
-    }
     public void setName(CharSequence text) {
         setName(String.valueOf(text));
     }
+    public void setName(String name) {
+        this.name = name;
+    }
     public String getUrl() {
         return url;
     }
-    public void setUrl(String url) {
-        this.url = url;
-    }
     public void setUrl(CharSequence text) {
         setUrl(String.valueOf(text));
     }
+    public void setUrl(String url) {
+        this.url = url;
+    }
     public boolean isAuthEnabled() {
         return authEnabled;
     }
@@ -149,21 +133,21 @@ public final class MobileLedgerProfile {
     public String getAuthUserName() {
         return authUserName;
     }
-    public void setAuthUserName(String authUserName) {
-        this.authUserName = authUserName;
-    }
     public void setAuthUserName(CharSequence text) {
         setAuthUserName(String.valueOf(text));
     }
+    public void setAuthUserName(String authUserName) {
+        this.authUserName = authUserName;
+    }
     public String getAuthPassword() {
         return authPassword;
     }
-    public void setAuthPassword(String authPassword) {
-        this.authPassword = authPassword;
-    }
     public void setAuthPassword(CharSequence text) {
         setAuthPassword(String.valueOf(text));
     }
+    public void setAuthPassword(String authPassword) {
+        this.authPassword = authPassword;
+    }
     public void storeInDB() {
         SQLiteDatabase db = MLDB.getDatabase();
         db.beginTransaction();
@@ -273,8 +257,7 @@ public final class MobileLedgerProfile {
     }
     public void setOption(String name, String value) {
         Log.d("profile", String.format("setting option %s=%s", name, value));
-        SQLiteDatabase db = MLDB.getDatabase();
-        db.execSQL("insert or replace into options(profile, name, value) values(?, ?, ?);",
+        DbOpQueue.add("insert or replace into options(profile, name, value) values(?, ?, ?);",
                 new String[]{uuid, name, value});
     }
     public void setLongOption(String name, long value) {
@@ -283,13 +266,14 @@ public final class MobileLedgerProfile {
     public void removeFromDB() {
         SQLiteDatabase db = MLDB.getDatabase();
         Log.d("db", String.format("removing profile %s from DB", uuid));
+        db.beginTransaction();
         try {
-            db.beginTransaction();
-            db.execSQL("delete from profiles where uuid=?", new Object[]{uuid});
-            db.execSQL("delete from accounts where profile=?", new Object[]{uuid});
-            db.execSQL("delete from account_values where profile=?", new Object[]{uuid});
-            db.execSQL("delete from transactions where profile=?", new Object[]{uuid});
-            db.execSQL("delete from transaction_accounts where profile=?", new Object[]{uuid});
+            Object[] uuid_param = new Object[]{uuid};
+            db.execSQL("delete from profiles where uuid=?", uuid_param);
+            db.execSQL("delete from accounts where profile=?", uuid_param);
+            db.execSQL("delete from account_values where profile=?", uuid_param);
+            db.execSQL("delete from transactions where profile=?", uuid_param);
+            db.execSQL("delete from transaction_accounts where profile=?", uuid_param);
             db.setTransactionSuccessful();
         }
         finally {
@@ -351,13 +335,13 @@ public final class MobileLedgerProfile {
 //        Log.d("profile", String.format("Profile.getThemeId() returning %d", themeId));
         return this.themeId;
     }
+    public void setThemeId(Object o) {
+        setThemeId(Integer.valueOf(String.valueOf(o)).intValue());
+    }
     public void setThemeId(int themeId) {
 //        Log.d("profile", String.format("Profile.setThemeId(%d) called", themeId));
         this.themeId = themeId;
     }
-    public void setThemeId(Object o) {
-        setThemeId(Integer.valueOf(String.valueOf(o)).intValue());
-    }
     public void markTransactionsAsNotPresent(SQLiteDatabase db) {
         db.execSQL("UPDATE transactions set keep=0 where profile=?", new String[]{uuid});