NewTransItemHolder: prevent sync loops via model data observers

[mobile-ledger.git] / app / src / main / java / net / ktnx / mobileledger / ui / activity / NewTransactionItemHolder.java

diff --git a/app/src/main/java/net/ktnx/mobileledger/ui/activity/NewTransactionItemHolder.java b/app/src/main/java/net/ktnx/mobileledger/ui/activity/NewTransactionItemHolder.java
index 2e4c0e6ceaa360b56df4ceb97b4b2d96840ac882..3198cc1695597687063f781d53e16038c5f0ae74 100644 (file)
--- a/app/src/main/java/net/ktnx/mobileledger/ui/activity/NewTransactionItemHolder.java
+++ b/app/src/main/java/net/ktnx/mobileledger/ui/activity/NewTransactionItemHolder.java
@@ -35,6 +35,7 @@ import androidx.recyclerview.widget.RecyclerView;
 
 import net.ktnx.mobileledger.R;
 import net.ktnx.mobileledger.async.DescriptionSelectedCallback;
+import net.ktnx.mobileledger.model.Data;
 import net.ktnx.mobileledger.model.LedgerTransactionAccount;
 import net.ktnx.mobileledger.model.MobileLedgerProfile;
 import net.ktnx.mobileledger.ui.DatePickerFragment;
@@ -84,6 +85,9 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
         });
         tvDate.setOnClickListener(v -> pickTransactionDate());
 
+        mProfile = Data.profile.getValue();
+        if (mProfile == null) throw new AssertionError();
+
         MLDB.hookAutocompletionAdapter(tvDescription.getContext(), tvDescription,
                 MLDB.DESCRIPTION_HISTORY_TABLE, "description", false, adapter, mProfile);
         MLDB.hookAutocompletionAdapter(tvAccount.getContext(), tvAccount, MLDB.ACCOUNTS_TABLE,
@@ -117,15 +121,33 @@ class NewTransactionItemHolder extends RecyclerView.ViewHolder
 
         dateObserver = date -> {
             if (syncingData) return;
-            tvDate.setText(item.getFormattedDate());
+            syncingData = true;
+            try {
+                tvDate.setText(item.getFormattedDate());
+            }
+            finally {
+                syncingData = false;
+            }
         };
         descriptionObserver = description -> {
             if (syncingData) return;
-            tvDescription.setText(description);
+            syncingData = true;
+            try {
+                tvDescription.setText(description);
+            }
+            finally {
+                syncingData = false;
+            }
         };
         hintObserver = hint -> {
             if (syncingData) return;
-            tvAmount.setHint(hint);
+            syncingData = true;
+            try {
+                tvAmount.setHint(hint);
+            }
+            finally {
+                syncingData = false;
+            }
         };
         focusedAccountObserver = index -> {
             if ((index != null) && index.equals(getAdapterPosition())) {