Room takes over DB migrations

[mobile-ledger.git] / app / src / main / java / net / ktnx / mobileledger / utils / MobileLedgerDatabase.java

diff --git a/app/src/main/java/net/ktnx/mobileledger/utils/MobileLedgerDatabase.java b/app/src/main/java/net/ktnx/mobileledger/utils/MobileLedgerDatabase.java
index 78c325e1317ef7673fcd6e20119ec3254eb2e98e..911c2034bd13b34fab7f30c8cd74c8f3372336f1 100644 (file)
--- a/app/src/main/java/net/ktnx/mobileledger/utils/MobileLedgerDatabase.java
+++ b/app/src/main/java/net/ktnx/mobileledger/utils/MobileLedgerDatabase.java
@@ -18,125 +18,38 @@
 package net.ktnx.mobileledger.utils;
 
 import android.app.Application;
-import android.content.res.Resources;
-import android.database.SQLException;
 import android.database.sqlite.SQLiteDatabase;
 import android.database.sqlite.SQLiteOpenHelper;
 
 import androidx.lifecycle.MutableLiveData;
 
-import net.ktnx.mobileledger.BuildConfig;
 import net.ktnx.mobileledger.db.DB;
 
-import java.io.BufferedReader;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.InputStreamReader;
-import java.util.Locale;
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
 import static net.ktnx.mobileledger.utils.Logger.debug;
 
 public class MobileLedgerDatabase extends SQLiteOpenHelper {
     public static final MutableLiveData<Boolean> initComplete = new MutableLiveData<>(false);
-    public static final String DB_NAME = "MoLe.db";
-    private static final int LATEST_REVISION = 58;
-    private static final String CREATE_DB_SQL = "create_db";
-    private final Application mContext;
-    @Override
-    public void onOpen(SQLiteDatabase db) {
-        super.onOpen(db);
-        // force a check by Room to ensure everything is OK
-        // TODO: remove when all DB structure manipulation is via Room
-        DB.get()
-          .compileStatement("SELECT COUNT(*) FROM profiles");
-    }
     public MobileLedgerDatabase(Application context) {
-        super(context, DB_NAME, null, LATEST_REVISION);
+        super(context, DB.DB_NAME, null, DB.REVISION);
         debug("db", "creating helper instance");
-        mContext = context;
         super.setWriteAheadLoggingEnabled(true);
     }
 
     @Override
     public void onCreate(SQLiteDatabase db) {
-        debug("db", "onCreate called");
-        applyRevisionFile(db, CREATE_DB_SQL);
-    }
-
-    @Override
-    public void onConfigure(SQLiteDatabase db) {
-        super.onConfigure(db);
-        db.execSQL("pragma case_sensitive_like=ON;");
-        if (BuildConfig.DEBUG)
-            db.execSQL("PRAGMA foreign_keys=ON");
+        throw new IllegalStateException("Should not happen. Where's Room!?");
     }
     @Override
     public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
-        debug("db",
-                String.format(Locale.US, "needs upgrade from version %d to version %d", oldVersion,
-                        newVersion));
-        for (int i = oldVersion + 1; i <= newVersion; i++)
-            applyRevision(db, i);
-    }
-    private void applyRevision(SQLiteDatabase db, int rev_no) {
-        String rev_file = String.format(Locale.US, "sql_%d", rev_no);
-
-        applyRevisionFile(db, rev_file);
+        throw new IllegalStateException("Should not happen. Where's Room!?");
     }
-    private void applyRevisionFile(SQLiteDatabase db, String revFile) {
-        final Resources rm = mContext.getResources();
-        int res_id = rm.getIdentifier(revFile, "raw", mContext.getPackageName());
-        if (res_id == 0)
-            throw new SQLException(String.format(Locale.US, "No resource for %s", revFile));
 
-        try (InputStream res = rm.openRawResource(res_id)) {
-            debug("db", "Applying " + revFile);
-            InputStreamReader isr = new InputStreamReader(res);
-            BufferedReader reader = new BufferedReader(isr);
-
-            Pattern endOfStatement = Pattern.compile(";\\s*(?:--.*)?$");
-
-            String line;
-            String sqlStatement = null;
-            int lineNo = 0;
-            while ((line = reader.readLine()) != null) {
-                lineNo++;
-                if (line.startsWith("--"))
-                    continue;
-                if (line.isEmpty())
-                    continue;
-
-                if (sqlStatement == null)
-                    sqlStatement = line;
-                else
-                    sqlStatement = sqlStatement.concat(line);
-
-                Matcher m = endOfStatement.matcher(line);
-                if (!m.find())
-                    continue;
-
-                try {
-                    db.execSQL(sqlStatement);
-                    sqlStatement = null;
-                }
-                catch (Exception e) {
-                    throw new RuntimeException(
-                            String.format("Error applying %s, line %d, statement: %s", revFile,
-                                    lineNo, sqlStatement), e);
-                }
-            }
-
-            if (sqlStatement != null)
-                throw new RuntimeException(String.format(
-                        "Error applying %s: EOF after continuation. Line %s, Incomplete " +
-                        "statement: %s", revFile, lineNo, sqlStatement));
-
-        }
-        catch (IOException e) {
-            throw new RuntimeException(String.format("Error opening raw resource for %s", revFile),
-                    e);
-        }
+    @Override
+    public void onConfigure(SQLiteDatabase db) {
+        super.onConfigure(db);
+        // force a check by Room to ensure everything is OK
+        // TODO: remove when all DB access is via Room
+        DB.get()
+          .compileStatement("SELECT COUNT(*) FROM profiles");
     }
 }