the date indicators are handled at an upper level
package net.ktnx.mobileledger.model;
package net.ktnx.mobileledger.model;
+import android.support.annotation.NonNull;
+
import java.util.Date;
public class TransactionListItem {
import java.util.Date;
public class TransactionListItem {
this.type = Type.TRANSACTION;
this.transaction = transaction;
}
this.type = Type.TRANSACTION;
this.transaction = transaction;
}
public Type getType() {
return type;
}
public Type getType() {
return type;
}
public void onBindViewHolder(@NonNull TransactionRowHolder holder, int position) {
TransactionListItem item = TransactionListViewModel.getTransactionListItem(position);
public void onBindViewHolder(@NonNull TransactionRowHolder holder, int position) {
TransactionListItem item = TransactionListViewModel.getTransactionListItem(position);
+ // in a race when transaction value is reduced, but the model hasn't been notified yet
+ // the view will disappear when the notifications reaches the model, so by simply omitting
+ // the out-of-range get() call nothing bad happens - just a to-be-deleted view remains
+ // a bit longer
+ if (item == null) return;
+
if (item.getType() == TransactionListItem.Type.TRANSACTION) {
holder.vTransaction.setVisibility(View.VISIBLE);
holder.vDelimiter.setVisibility(View.GONE);
LedgerTransaction tr = item.getTransaction();
if (item.getType() == TransactionListItem.Type.TRANSACTION) {
holder.vTransaction.setVisibility(View.VISIBLE);
holder.vDelimiter.setVisibility(View.GONE);
LedgerTransaction tr = item.getTransaction();
- // in a race when transaction value is reduced, but the model hasn't been notified yet
- // the view will disappear when the notifications reaches the model, so by simply omitting
- // the out-of-range get() call nothing bad happens - just a to-be-deleted view remains
- // a bit longer
- if (tr == null) return;
-
- LedgerTransaction previous = null;
- TransactionListItem previousItem = null;
- if (position > 0)
- previousItem = TransactionListViewModel.getTransactionListItem(position - 1);
// Log.d("transactions", String.format("Filling position %d with %d accounts", position,
// tr.getAccounts().size()));
TransactionLoader loader = new TransactionLoader();
// Log.d("transactions", String.format("Filling position %d with %d accounts", position,
// tr.getAccounts().size()));
TransactionLoader loader = new TransactionLoader();
- loader.execute(
- new TransactionLoaderParams(tr, previous, holder, position, boldAccountName));
+ loader.execute(new TransactionLoaderParams(tr, holder, position, boldAccountName));
// WORKAROUND what seems to be a bug in CardHolder somewhere
// when a view that was previously holding a delimiter is re-purposed
// WORKAROUND what seems to be a bug in CardHolder somewhere
// when a view that was previously holding a delimiter is re-purposed
@Override
protected Void doInBackground(TransactionLoaderParams... p) {
LedgerTransaction tr = p[0].transaction;
@Override
protected Void doInBackground(TransactionLoaderParams... p) {
LedgerTransaction tr = p[0].transaction;
- LedgerTransaction previous = p[0].previousTransaction;
SQLiteDatabase db = MLDB.getReadableDatabase();
tr.loadData(db);
SQLiteDatabase db = MLDB.getReadableDatabase();
tr.loadData(db);
- boolean showDate;
- if (previous == null) showDate = true;
- else {
- previous.loadData(db);
- showDate = !previous.getDate().equals(tr.getDate());
- }
- publishProgress(new TransactionLoaderStep(p[0].holder, p[0].position, tr, showDate));
+ publishProgress(new TransactionLoaderStep(p[0].holder, p[0].position, tr));
int rowIndex = 0;
for (LedgerTransactionAccount acc : tr.getAccounts()) {
int rowIndex = 0;
for (LedgerTransactionAccount acc : tr.getAccounts()) {
}
private class TransactionLoaderParams {
}
private class TransactionLoaderParams {
- LedgerTransaction transaction, previousTransaction;
+ LedgerTransaction transaction;
TransactionRowHolder holder;
int position;
String boldAccountName;
TransactionRowHolder holder;
int position;
String boldAccountName;
- TransactionLoaderParams(LedgerTransaction transaction, TransactionRowHolder holder, int position, String boldAccountName) {
- this(transaction, null, holder, position, boldAccountName);
- }
- TransactionLoaderParams(LedgerTransaction transaction,
- LedgerTransaction previousTransaction, TransactionRowHolder holder,
+ TransactionLoaderParams(LedgerTransaction transaction, TransactionRowHolder holder,
int position, String boldAccountName) {
this.transaction = transaction;
int position, String boldAccountName) {
this.transaction = transaction;
- this.previousTransaction = previousTransaction;
this.holder = holder;
this.position = position;
this.boldAccountName = boldAccountName;
this.holder = holder;
this.position = position;
this.boldAccountName = boldAccountName;
private LedgerTransactionAccount account;
private int accountPosition;
private String boldAccountName;
private LedgerTransactionAccount account;
private int accountPosition;
private String boldAccountName;
- private boolean showDate;
public TransactionLoaderStep(TransactionRowHolder holder, int position,
public TransactionLoaderStep(TransactionRowHolder holder, int position,
- LedgerTransaction transaction, boolean showDate) {
+ LedgerTransaction transaction) {
this.step = TransactionListAdapter.LoaderStep.HEAD;
this.holder = holder;
this.transaction = transaction;
this.position = position;
this.step = TransactionListAdapter.LoaderStep.HEAD;
this.holder = holder;
this.transaction = transaction;
this.position = position;
- this.showDate = showDate;
}
public TransactionLoaderStep(TransactionRowHolder holder, LedgerTransactionAccount account,
int accountPosition, String boldAccountName) {
}
public TransactionLoaderStep(TransactionRowHolder holder, LedgerTransactionAccount account,
int accountPosition, String boldAccountName) {
public LedgerTransactionAccount getAccount() {
return account;
}
public LedgerTransactionAccount getAccount() {
return account;
}
- public boolean isDateShown() {
- return showDate;
- }